Demote per-file directive skip logs to DEBUG (M13.5)#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit 13 M13.5: `dlm show` on a 2,021-file source-directive document
emits 243 `directive: ... exceeds max_bytes_per_file=...; skipping`
lines to stderr — once per oversize file, every invocation. The
audit explicitly flagged this as a 1-2s/call hit + log noise.
This change demotes all per-file skip logs in `directives/expand.py`
from INFO to DEBUG:
WARNING-level logs for genuine read/stat/UTF-8 failures stay loud —
those indicate something the user might want to fix. The summary
count is still surfaced via `provenance.skipped_*` (and via the
trainer's `directives: expanded N file(s) across M source(s)` line).
A separate caching layer for the expansion result is the right
follow-up to address the re-walk cost — out of scope for this
fix; tracked for a future sprint.
Test plan