CX1: HTTPError fills empty message with request path#314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
messageinHTTPError(w, r, status, "")callsites now falls back toreq.URL.Pathso the rendered 404 template names the URL the user tried to reach instead of rendering<code></code>. Most user-visible at the post-login-redirect → 404 path (deleted repo URL).?token=...&return_to=...) into rendered HTML.HTTPError(only reached when the error template itself fails to render) totemplate.HTMLEscapeStringthe now-user-controllablemessage+request_idbeforeFprintf— closes the gosec G705 taint flow my change introduced.Test plan
go test ./internal/web/render/— new tests pass:TestHTTPError_EmptyMessageFallsBackToRequestPath—/octocat/hello-worldrenders in bodyTestHTTPError_FallbackOmitsQueryString—?token=secretdoes not leak into outputTestHTTPError_ExplicitMessageWins— non-empty caller message preserved verbatimgolangci-lint run ./internal/web/render/...— 0 issuesgo build ./...— cleanshithub.shpost-login redirect to deleted repo, confirm the 404 page now names the URL instead of<code></code>Closes audit finding CX1.