Skip to content

fix available bids maxTaker logic#100

Merged
samuelvanderwaal merged 1 commit intomainfrom
leant/max-taker-logic-fix
Mar 3, 2025
Merged

fix available bids maxTaker logic#100
samuelvanderwaal merged 1 commit intomainfrom
leant/max-taker-logic-fix

Conversation

@leantOnSol
Copy link
Contributor

issue: while in 99% of cases pool.poolOffset == pool.stats.takerSellCount - pool.stats.takerBuyCount, this doesn't apply when the pool gets edited with resetPriceOffset = true ==> in this case, poolOffset is needed for price calculation, but pool.stats.takerSellCount - pool.stats.takerBuyCount is needed for comparing against pool.maxTakerSellCount

  • fixes maxTakerSellCount related helper functions to use pool.stats.takerSellCount - pool.stats.takerBuyCount instead of pool.poolOffset to compare against pool.maxTakerSellCount

@socket-security
Copy link

@samuelvanderwaal samuelvanderwaal merged commit 455e3eb into main Mar 3, 2025
11 checks passed
@samuelvanderwaal samuelvanderwaal deleted the leant/max-taker-logic-fix branch March 3, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants