Skip to content

Leant/post migration adjustments#46

Merged
richardwu merged 5 commits intomainfrom
leant/post-migration-adjustments
Jun 26, 2025
Merged

Leant/post migration adjustments#46
richardwu merged 5 commits intomainfrom
leant/post-migration-adjustments

Conversation

@leantOnSol
Copy link
Contributor

  • removes wlv1 + mpv1 handlers (leave state for minimally invasive changes)
  • removes wlv1 + mpv1 related ix + account + pda generation in clients
  • fixes CI (bump internal actions, update CODEOWNERS)

@leantOnSol leantOnSol requested a review from richardwu as a code owner June 23, 2025 15:26
VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }}
VERCEL_PROJECT_ID: ${{ secrets.VERCEL_PROJECT_ID }}
working-directory: ./clients/js
run: echo "url=$(vercel deploy --prod --token=${{ secrets.VERCEL_TOKEN }})" | tee $GITHUB_OUTPUT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more JS docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of scope atm, we haven't deployed + hosted SDK docs - can work on that eventually in the future

@@ -98,290 +96,4 @@ describe("tensor whitelist", () => {
expect(authAcc.owner.toBase58()).to.eq(tlistOwner.publicKey.toBase58());
});

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have whitelist v2 tests somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep! a lot of wlv2 + mpv2 tests under clients/js/tests

"[accountNode]whitelist",
]),
);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting: how come they still render here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still have the account states in our program for backwards compat / minimally invasive changes for actual whitelist verifications => so even w/o their corresponding handlers, the accounts would still render into clients (thus "manual" removal here)

@richardwu richardwu merged commit 14095a1 into main Jun 26, 2025
14 checks passed
@richardwu richardwu deleted the leant/post-migration-adjustments branch June 26, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants