Conversation
leantOnSol
commented
Jun 23, 2025
- removes wlv1 + mpv1 handlers (leave state for minimally invasive changes)
- removes wlv1 + mpv1 related ix + account + pda generation in clients
- fixes CI (bump internal actions, update CODEOWNERS)
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
| VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }} | ||
| VERCEL_PROJECT_ID: ${{ secrets.VERCEL_PROJECT_ID }} | ||
| working-directory: ./clients/js | ||
| run: echo "url=$(vercel deploy --prod --token=${{ secrets.VERCEL_TOKEN }})" | tee $GITHUB_OUTPUT |
There was a problem hiding this comment.
out of scope atm, we haven't deployed + hosted SDK docs - can work on that eventually in the future
| @@ -98,290 +96,4 @@ describe("tensor whitelist", () => { | |||
| expect(authAcc.owner.toBase58()).to.eq(tlistOwner.publicKey.toBase58()); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Do we have whitelist v2 tests somewhere?
There was a problem hiding this comment.
yep! a lot of wlv2 + mpv2 tests under clients/js/tests
| "[accountNode]whitelist", | ||
| ]), | ||
| ); | ||
|
|
There was a problem hiding this comment.
Interesting: how come they still render here?
There was a problem hiding this comment.
we still have the account states in our program for backwards compat / minimally invasive changes for actual whitelist verifications => so even w/o their corresponding handlers, the accounts would still render into clients (thus "manual" removal here)