Add :serial and :meander unfolding schemes#22
Add :serial and :meander unfolding schemes#22apkille wants to merge 2 commits intotensor4all:mainfrom
:serial and :meander unfolding schemes#22Conversation
|
Hi @apkille , and thank you for this pull request! Unfortunately, it has a bit of an inopportune timing, since we're working on merging #21, which enables users of this library to choose the index order freely. The schemes If it's ok with you, I'll keep this pull request open for now. I'll work on merging #21 first, then implement your keywords, which have well-chosen names, and use your tests for the newer implementation. |
|
Yep, that's OK with me! I will also submit the supporting PR for the unfolding schemes with QuanticsTCI.jl. By the way, the packages in this GitHub org are very impressive and fast. Using them makes my life a whole lot easier :) |
|
#21 has been merged into the main. How should we proceed? |
These unfolding schemes complement the already implemented :interleaved and :fused schemes. I wrote them up for a project testing the performance of different quantics bases for multivariate functions in different settings. It's possible they could be of use to others. If the package maintainers disagree and want to close this PR, that's perfectly fine! If it gets merged I can follow up with a PR to QuanticsTCI.jl for support in the TCI interface.