Implementing derivatives with periodic bc in QTT format.#9
Open
sakurairihito wants to merge 1 commit intotensor4all:mainfrom
Open
Implementing derivatives with periodic bc in QTT format.#9sakurairihito wants to merge 1 commit intotensor4all:mainfrom
sakurairihito wants to merge 1 commit intotensor4all:mainfrom
Conversation
Author
|
I found an issue in my source and test code in this pull request, which is related to the mesh size (\Delta = 1 / 2^R), where (R) is the number of bits. In the current pull requests, the derivative operator incorrectly uses (\Delta). Instead, we should apply (1/\Delta) to the derivative operator. For instance, the function function first_order_central_difference_periodic(R::Int64)::Vector{Array{Float64,4}}
c1 = 1 / 2
t_left = zeros(1, 2, 2, 3)
t_left[1, :, :, 1] = I() * 2^R
t_left[1, :, :, 2] = (S(:plus) + S(:minus)) * 2^R
t_left[1, :, :, 3] = (S(:plus) + S(:minus)) * 2^RThe function of second_order_derivative and test code should be corrected as the same way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request (PR) for the following implementations:
Note that the code does not depend on ITensors.jl. I would appreciate it if you could check it. Any comments and improvements on codes are welcome. If needed, other types of derivatives can be implemented. Thank you.
Reference Papers