Switch default copy strategy from source-stride-order to HPTT#119
Merged
Switch default copy strategy from source-stride-order to HPTT#119
Conversation
Replace copy_strided_src_order with strided_kernel::copy_into_col_major (HPTT) in prepare_input_owned, matching what prepare_input_view already uses. Remove the now-dead copy_strided_src_order and copy_strided_src_order_par functions. Benchmarks show HPTT outperforms source-stride-order on 8/10 instances (16-43% faster). Even on the two instances where source-order was faster (tn_focus/tn_light), copy elision compensates and Rust still outperforms Julia's OMEinsum.jl. Closes #118 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copy_strided_src_orderwithstrided_kernel::copy_into_col_major(HPTT) inprepare_input_owned, matching whatprepare_input_viewalready usescopy_strided_src_orderandcopy_strided_src_order_par(~170 lines)Benchmark evidence
Direct comparison with copy elision disabled (opt_flops, 1T, AMD EPYC 7713P):
HPTT wins on 8/10 instances. The two instances where src-order wins (tn_focus/tn_light) still outperform Julia's OMEinsum.jl thanks to copy elision.
Test plan
cargo testandcargo test --features parallel)Closes #118
🤖 Generated with Claude Code