Merged
Conversation
peytondmurray
requested changes
Oct 17, 2024
Contributor
peytondmurray
left a comment
peytondmurray
left a comment
There was a problem hiding this comment.
A few changes requested (thanks to the helpful comments here).
Sadly the use of unittest really highlights problems that apache-beam feels as a result of dill unconditionally trying to pickle arbitrary objects. Moving forward we should move away from unittest.TestCase methods for carrying out assertions such as self.assertEqual, as this requires pickling the unittest.TestCase itself - which fails. For now, xfailing makes sense.
Co-authored-by: Peyton Murray <peynmurray@gmail.com>
smokestacklightnin
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds test workflow for tfx-bsl.
TODO: