Fix expand/collapse feature with many apis#40
Merged
Conversation
- Refactored "Expand/Collapse All" logic to support dynamic Swagger UI content using retries and MutationObserver. - Prevented duplicate expand/collapse buttons with data attributes. - Updated minified file to reflect all changes.
teociaps
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates focused on improving advanced UI features for Swagger UI theme demos, cleaning up sample code and assets, and enhancing the robustness of UI scripts. The most significant changes include enabling advanced UI features by default in sample apps, removing unused custom theme files, and refactoring JavaScript logic for better reliability and maintainability.
Sample Application Enhancements:
Sample.AspNetCore.SwaggerUI.NSwagandSample.AspNetCore.SwaggerUI.Swashbucklesample apps, making demos more interactive and easier to showcase. [1] [2]Program.csfiles to emphasize the advanced features demos. [1] [2]Cleanup of Custom Theme Assets:
CustomTheme,CustomMinifiedStyle) and the sample custom CSS file (custom.css) from both sample projects, simplifying the codebase and eliminating dead code. [1] [2]JavaScript UI Improvements:
ui.jsto be more robust: added retry logic for dynamic rendering, prevented duplicate buttons, and ensured compatibility with incremental UI updates.ui.js: fixed edge cases for theme detection, enhanced stylesheet matching, and moved the theme detection function for better code organization. [1] [2] [3] [4] [5]