Skip to content

Run eslint on CI#487

Open
sryhanen wants to merge 1 commit into
teragrep:mainfrom
sryhanen:Issue-475/Run-eslint-on-CI
Open

Run eslint on CI#487
sryhanen wants to merge 1 commit into
teragrep:mainfrom
sryhanen:Issue-475/Run-eslint-on-CI

Conversation

@sryhanen
Copy link
Copy Markdown
Contributor

Description

Run eslint on CI.
Issue #475

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 15, 2026

CLA assistant check
All committers have signed the CLA.

@kortemik kortemik linked an issue Apr 29, 2026 that may be closed by this pull request
Comment thread pom.xml
<goal>exec</goal>
</goals>
<configuration>
<executable>bash</executable>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

executable must be yarn

Comment thread pom.xml
<executable>bash</executable>
<arguments>
<argument>-c</argument>
<argument>yarn lint:once || true</argument>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once executable is yarn || true can not be used to hide linter errors. The errors are the whole purpose of linting: please remove || true.

@sryhanen
Copy link
Copy Markdown
Contributor Author

sryhanen commented May 6, 2026

Is blocked by: #522
After #522, I will change the implementation so that eslint fail fails the CI run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make eslint run on normal CI build

3 participants