Separated Common objects from bigger PR#22
Open
Laukkala wants to merge 2 commits into
Open
Conversation
Nefarious46
requested changes
Jan 20, 2026
Nefarious46
left a comment
Nefarious46
left a comment
There was a problem hiding this comment.
Main classes looked good with some very minor fixes. I am unsure what to say about unit testing.
| } | ||
|
|
||
| public ErrorEvent(final Throwable exception, final UUID eventId) { | ||
| LOGGER.error("Event_" + eventId, exception); |
There was a problem hiding this comment.
Suggested change
| LOGGER.error("Event_" + eventId, exception); | |
| LOGGER.error("Event {} with exception {}" , eventId, exception); |
I suggest using parameterized logging to avoid string concatination.
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class NotebookServerTest extends AbstractNotebookServerTest { |
There was a problem hiding this comment.
Should AbstractNotebookServerTest.java be a fake class?
| import java.nio.file.Paths; | ||
|
|
||
| // A simple main class for configuring and starting one or more NotebookServer threads. | ||
| public class TestServer { |
There was a problem hiding this comment.
Should this be here? AbstractNoteBookServerTest.java has same contents but more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is separated from #4 to make code review more manageable.
Note that this PR by itself will likely contain references to objects that are not present in this PR. Please refer to PR #4, which contains all objects, in case you need to see how some objects interact.
This PR contains common objects that do not fit any other of the related PRs.
closes #18