Issue 320 separated angular forms messages#321
Draft
Laukkala wants to merge 6 commits into
Draft
Conversation
SUBMIT_FORM now combines the form values with existing ones instead of replacing them.
…ingle Dynamic form. Previously you had to set all values at once
…ms if no "params" parameter is provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently angular forms are updated using COMMIT_PARAGRAPH and SAVE_NOTE_FORMS messages and UI receives saved values via PARAGRAPH and SAVE_NOTE_FORMS messages. These should be separated to their own message types
This PR includes a separated PARAGRAPH_FORM message, which contains paragraph form information.
Also a new SUBMIT_FORM message is accepted by server, which allows UI to set the value of a paragraph form
Checklists
Testing
General
Assertions
Testing Data
Statements
Java
Other
Code Quality