Skip to content
This repository was archived by the owner on Aug 2, 2024. It is now read-only.

Add winston#98

Open
ullrichd21 wants to merge 1 commit intomainfrom
winston-logging
Open

Add winston#98
ullrichd21 wants to merge 1 commit intomainfrom
winston-logging

Conversation

@ullrichd21
Copy link

Added Winston logging.

This is the bare minimum for Winston.

Questions:

  1. Where should we pipe logs, currently it's the Console however should we potentially do a file?
  2. What else needs to be logged?

Let's leave this PR open until those questions are answered and this PR is a bit more substantial.

@ullrichd21 ullrichd21 requested a review from dluman November 10, 2022 14:33
@dluman
Copy link
Contributor

dluman commented Nov 13, 2022

We might consider throwing logs to /var/log? Since you bring up logging, what is worth tracking under the auspices of #60? It's not really a log, but would go the same place, potentially. Something like /var/log/world might be appropriate in the way that a software like Apache has error, auth, and other misc logs.

Mostly, I think we're concerned with things that are of the different levels: warn, error and info, but what constitutes each is an open question. There have been a couple of moments recently when the daemon has gone down. I'd like to at least start with those.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants