Initial fix for the vars issue for #378#381
Open
hoijnet wants to merge 1 commit into
Open
Conversation
dfrnt-HansKochstein
approved these changes
Apr 28, 2026
dfrnt-HansKochstein
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(types): accept
Varin WOQL document and list functions (#378)Several WOQL functions —
read_document,delete_document,insert_document,update_document,length,sub,idgen_random, andrandom_idgen— had TypeScript signatures that only acceptedstringfor parameters that the runtime has always accepted as either a string variable reference ("v:foo") or aVarobject (fromWOQL.vars()). This made the two styles inconsistent at the type level despite being equivalent at runtime, forcing users to add@ts-ignoreworkarounds.The root cause was incorrect JSDoc
@paramannotations inlib/woql.jsandlib/query/woqlQuery.js. The.d.tsis auto-generated from those annotations vianpm run generate-types— editing the declaration file directly would be overwritten on the next build.This PR corrects the annotations for the affected functions, regenerates the type declarations, and adds integration tests covering the
Var-as-argument pattern forread_documentandlength. A broader sweep of all ~144 exported functions is included to catch any remaining cases where binding-slot parameters were incorrectly typed as plainstring.