bugfix: invalidate full parent chain in register_rollup to prevent cache accumulation#157
Open
hoijnet wants to merge 4 commits into
Open
bugfix: invalidate full parent chain in register_rollup to prevent cache accumulation#157hoijnet wants to merge 4 commits into
hoijnet wants to merge 4 commits into
Conversation
… accumulation Previously, register_rollup only invalidated the single rolled-up layer from cache. This left ancestor layers cached with Arc references, causing memory accumulation and O(n) performance degradation during high commit rates with rollups. Now traverses the full layer stack and invalidates all ancestors, ensuring old parent chains become eligible for cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, register_rollup only invalidated the single rolled-up layer from cache. This left ancestor layers cached with Arc references, causing memory accumulation and O(n) performance degradation during high commit rates with rollups.
Now traverses the full layer stack and invalidates all ancestors, ensuring old parent chains become eligible for cleanup.
Also add cache statistics which can help understand the cache better.