fix: use patch rather than git for patching the vendored modules#2
Conversation
|
I added |
This way distro build systems don't need to setup git (`user.email` and `user.name`).
|
If it makes upstreaming easier then always 😄 Added an option for it. |
|
would it be possible to move the option declaration in vendor/CMakeLists.txt after the previous option line? |
|
It would but as a distro packager I can say from experience that I much rather have projects defining all possible build options in a single place so they're easy to find and hard to miss. I find it annoying to have options that modify the build scattered throughout several files, in practice that just means I miss them and am missing out on a lot of configuration. |
|
Oh, I agree with that point. I'll move the other two options after it in next commit. |
This way distro build systems don't need to setup git (
user.emailanduser.name).