chore(deps): chokidar 3→5 major#63
Merged
Merged
Conversation
chokidar v4+ removed glob support: the `ignored` option no longer treats string matchers as globs. Convert FileWatcher's glob ignorePatterns to a micromatch-based match function so node_modules/.git/dist stay ignored. Watch targets were already directories (patterns filtered post-event via micromatch), so no path-glob migration needed.
# Conflicts: # package-lock.json # packages/autonav/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
chokidar^3.5.3→^5.0.0in@autonav/core(the only declaring package).Migration
chokidar v4+ dropped glob support. The FileWatcher already watched directories (
config.paths) and filtered events with micromatch post-hoc, so watch targets needed no change. The one break: theignoredoption no longer interprets string matchers as globs (they're literal paths now). ConvertedignorePatterns(**/node_modules/**,**/.git/**,**/dist/**) to a micromatch-basedMatchFunctionso those keep being ignored.watch/FSWatcherimports andadd/change/unlinkevents unchanged.Note: chokidar 5 requires Node >= 20.19.0.
Test
npm run typecheck(also builds) → pass, all 3 workspacesnpm test→ pass: 112 core + 45 communication-layer tests (22 skipped), 0 failures