Skip to content

chore: Use GetBytesFromBase64 / WriteBase64StringValue to avoid string allocations #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HofmeisterAn merged 1 commit into from
Mar 4, 2026
Merged

chore: Use GetBytesFromBase64 / WriteBase64StringValue to avoid string allocations #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/Docker.DotNet/Base64Converter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,11 @@ internal class Base64Converter : JsonConverter<IList<byte>>
{
public override IList<byte> Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
{
var base64String = reader.GetString();
return base64String == null ? null : Convert.FromBase64String(base64String);
return reader.GetBytesFromBase64();
}

public override void Write(Utf8JsonWriter writer, IList<byte> value, JsonSerializerOptions options)
{
var base64String = Convert.ToBase64String(value.ToArray());
writer.WriteStringValue(base64String);
writer.WriteBase64StringValue(value.ToArray());
}
}
Loading