chore(examples): Enable NuGet restore lock mode#1659
Merged
HofmeisterAn merged 2 commits intodevelopfrom Mar 11, 2026
Merged
Conversation
HofmeisterAn
added
the
chore
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (14)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughAdds NuGet lockfile support to the WeatherForecast example: enables RestorePackagesWithLockFile, uses --locked-mode in the Docker restore, generates packages.lock.json files for projects, updates package references/FluentUI namespace, and adjusts a WebDriver test wait usage. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@examples/WeatherForecast/tests/WeatherForecast.InProcess.Tests/packages.lock.json`:
- Around line 534-541: The project has a transitive dependency on
System.Text.Json 7.0.4 (via Microsoft.Fast.Components.FluentUI 3.8.0) which is
vulnerable (CVE-2024-30105); fix by adding an explicit PackageReference for
System.Text.Json version 8.0.4 or later in the project file (override the
transitive version) or, alternatively, upgrade
Microsoft.Fast.Components.FluentUI to a version that itself depends on
System.Text.Json >= 8.0.4; make sure the explicit package reference
xmlns/includes the desired Version="8.0.4" (or higher) to force NuGet to resolve
the safe version.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 4c72e3c7-ac8e-4d43-8df1-bd88e5c56d74
📒 Files selected for processing (9)
examples/WeatherForecast/Directory.Build.propsexamples/WeatherForecast/Dockerfileexamples/WeatherForecast/src/WeatherForecast.Contexts/packages.lock.jsonexamples/WeatherForecast/src/WeatherForecast.Entities/packages.lock.jsonexamples/WeatherForecast/src/WeatherForecast.Interactors/packages.lock.jsonexamples/WeatherForecast/src/WeatherForecast.Repositories/packages.lock.jsonexamples/WeatherForecast/src/WeatherForecast/packages.lock.jsonexamples/WeatherForecast/tests/WeatherForecast.InProcess.Tests/packages.lock.jsonexamples/WeatherForecast/tests/WeatherForecast.Tests/packages.lock.json
examples/WeatherForecast/tests/WeatherForecast.InProcess.Tests/packages.lock.json
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable the NuGet restore lock mode for the WeatherForecast example.
Why is it important?
-
Related issues
-
Summary by CodeRabbit