feat(container): add Container.with_name/2#255
Merged
Conversation
Adds a `name` field (default nil) to the `Testcontainers.Container` struct and a `with_name/2` builder that assigns a custom name to the container at creation time, wired through to Docker's `/containers/create` `name` query parameter. This lets users give a container a stable, well-known name (like `docker run --name foo`) so other containers on the same network can reference it by that name. Fixes #177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
namefield (defaultnil) to theTestcontainers.Containerstruct and awith_name/2builder styled like the otherwith_*helpers.container.nameintoDocker.Api.create_container/2so it is passed as thenamequery parameter to Docker's/containers/createendpoint.docker run --name foo) so other containers on the same network can reference it by name.Test plan
mix compile(no new warnings)mix credo --strict(no issues)mix dialyzer(0 errors)mix test test/container_test.exs— unit tests cover defaultnil, setting a name, and overwriting a previously set namemix test test/testcontainers_test.exs— integration test starts a container with a custom name and asserts Docker assigned it (/<name>)Fixes #177