Skip to content

Fix host UID/GID leakage in copyFileToContainer TAR entries #11929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gautam-aman wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −0
Open

Fix host UID/GID leakage in copyFileToContainer TAR entries #11929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/main/java/org/testcontainers/utility/MountableFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,10 @@ private void recursiveTar(
}

final TarArchiveEntry tarEntry = new TarArchiveEntry(sourceFile, tarEntryFilename.replaceAll("^/", ""));
tarEntry.setUserId(0);
tarEntry.setGroupId(0);
tarEntry.setUserName("root");
tarEntry.setGroupName("root");

// TarArchiveEntry automatically sets the mode for file/directory, but we can update to ensure that the mode is set exactly (inc executable bits)
tarEntry.setMode(getUnixFileMode(itemPath));
Expand Down
22 changes: 22 additions & 0 deletions core/src/test/java/org/testcontainers/utility/MountableFileTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import lombok.Cleanup;
import org.apache.commons.compress.archivers.ArchiveEntry;
import org.apache.commons.compress.archivers.tar.TarArchiveEntry;
import org.apache.commons.compress.archivers.tar.TarArchiveInputStream;
import org.apache.commons.compress.archivers.tar.TarArchiveOutputStream;
import org.jetbrains.annotations.NotNull;
Expand Down Expand Up @@ -32,6 +33,27 @@ void forClasspathResource() throws Exception {
performChecks(mountableFile);
}

@Test
void tarEntriesShouldUseRootOwnership() throws Exception {
final Path file = createTempFile("ownership-test.txt");
final MountableFile mountableFile = MountableFile.forHostPath(file);

@Cleanup
final TarArchiveInputStream tais = intoTarArchive(taos -> {
mountableFile.transferTo(taos, "/ownership-test.txt");
});

final TarArchiveEntry tarEntry = tais.getNextEntry();

assertThat(tarEntry).isNotNull();

System.out.println("UID = " + tarEntry.getLongUserId());
System.out.println("GID = " + tarEntry.getLongGroupId());

assertThat(tarEntry.getLongUserId()).isZero();
assertThat(tarEntry.getLongGroupId()).isZero();
}

@Test
void forClasspathResourceWithAbsolutePath() throws Exception {
final MountableFile mountableFile = MountableFile.forClasspathResource("/mappable-resource/test-resource.txt");
Expand Down