fix: correct check for existing replacements#109
Open
JakobJingleheimer wants to merge 4 commits intotestdouble:mainfrom
Open
fix: correct check for existing replacements#109JakobJingleheimer wants to merge 4 commits intotestdouble:mainfrom
JakobJingleheimer wants to merge 4 commits intotestdouble:mainfrom
Conversation
Contributor
Author
|
The test-case "support importing esm and returning the path even when bare-specifier quibbled" is failing locally (but apparently not in CI??), but I'm not sure why—I added some logs, and their output is what I expect. log outputNote that I manually replaced irrelevantly long parts of URLs below with It fails with (I prettied up the output): Based on the description, I think the expected value is wrong—the description seems to say the result should be "quibbled". |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quibbleLoaderState.quibbledModulesis initialised as aMapin the root of the module, and it is never voided (only replaced with a fresh Map on "reset"), so the empty Map would never fail a falsy test because an empty Map is still truthy (so instead check whether it's emtpy).To verify, run against JakobJingleheimer/td-global-mock@0008fb5 (
npm testwill error if this fix doesn't work).This partially fixes testdouble/testdouble.js#528, but it doesn't address all cases.