Fix empty result for HTTPS_RR for Mac and friends#3078
Open
drwetter wants to merge 2 commits into
Open
Conversation
... also improve error handling by adding return values in *https_rr functions. The error for ~Macs occured because for interpretation of raw TYPE65 DNS data it was just 1 returned instead of 0 --for empty records.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... also improve error handling by adding return values in *https_rr functions.
The error for ~Macs occured because for interpretation of raw TYPE65 DNS data it was just 1 returned instead of 0 --for empty records.
What is your pull request about?
If it's a code change please check the boxes which are applicable
help()AI section
[e.g. GitHub CoPilot, JetBrains Junie, VS Code plugin <NAME> etc.][e.g. GPT-A.B, Claude <NAME> A.B, Gemini A.B <NAME>, Qwen<B>-Coder, DeepSeek-<A> etc.]