Force Big Boy room music to be correct prior to baby skip attempt#249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue was found using custom door portals. The two rooms prior to Big Boy room prepare boss music, but Big Boy room itself does not since Samus is free to re-enter Big Boy room afterwards and it would not make sense to have boss music. However the baby skip cutscene does require the music track to be prepared or else the music sounds bad; it even crashed on someone's emulator (although it did not crash for me on console... but it did sound bad when getting grabbed by baby). Anyway, fixing the music is both the right thing to do for practicing baby skip using custom portal and it should also avoid sound crashes.
It's worth noting that, while connecting custom door portal to the room prior to Big Boy room would avoid the crash, it's not a great solution. Connecting a custom door portal to Big Boy room causes the map rando sped-up version of the hopper cutscene to play out, which could be useful for practicing things like bomb spread baby skip method for map rando, so there is a reason to set up the portal this way. While I'm sure I tested this scenario in the past, I must have had the music turned off when testing.