Skip to content

fix: make default filter read-only#119

Merged
alyldas merged 1 commit into
mainfrom
fix/immutable-default-filter
Jun 22, 2026
Merged

fix: make default filter read-only#119
alyldas merged 1 commit into
mainfrom
fix/immutable-default-filter

Conversation

@alyldas

@alyldas alyldas commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • Made the shared default filter reject mutation methods while keeping check, censor, and analyze available.
  • Kept factory-created and dictionary-created filters mutable for isolated runtime dictionaries.
  • Updated API tests and README guidance for default-vs-factory usage.

Tests:

  • npm test -- --run tests/api.spec.ts tests/curated-regression.spec.ts
  • npm run check (using a temporary npm cache outside the user home)

Do not merge until maintainer approval.

Closes #115

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3e8370342a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/filter.ts Outdated
@alyldas alyldas force-pushed the fix/immutable-default-filter branch from 3e83703 to 17f1a77 Compare June 22, 2026 08:26
@alyldas alyldas merged commit 6055bb1 into main Jun 22, 2026
4 checks passed
@alyldas alyldas deleted the fix/immutable-default-filter branch June 22, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Make the default profanity filter immutable

1 participant