fix: remove redundant rule id from diagnostic message#32
Open
314systems wants to merge 1 commit into
Open
Conversation
The rule id was shown twice in the VS Code diagnostic hover: once embedded in the message text and once as the diagnostic code. Drop the embedded copy and keep the code so it is displayed only once.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #31 where VS Code’s diagnostic hover displayed the textlint rule id twice by removing the rule id suffix from the diagnostic message while keeping the rule id in the diagnostic code field.
Changes:
- Stop appending
(${ruleId})to the LSP diagnosticmessagein the textlint server. - Update extension integration test expectations to match the new diagnostic message text.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/textlint-server/src/server.ts | Removes rule id concatenation from Diagnostic.message while retaining Diagnostic.code = ruleId. |
| packages/textlint/test/extension.test.ts | Updates expected diagnostics’ message strings to no longer include the rule id suffix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #31