Properly handle n_results to query the correct number of papers.#384
Open
ch-schiffer wants to merge 1 commit into
Open
Properly handle n_results to query the correct number of papers.#384ch-schiffer wants to merge 1 commit into
ch-schiffer wants to merge 1 commit into
Conversation
Owner
|
@ch-schiffer thank you so much ❤️ |
thawn
requested changes
Jun 13, 2026
thawn
left a comment
thawn
left a comment
Owner
There was a problem hiding this comment.
thanks again for this PR! It would be great if you could implement the comments below, so that I can merge the PR.
| ctx: RunContext[RAGDeps], | ||
| topic_keywords: str, | ||
| n_results: int = 5, | ||
| n_results: Optional[int] = None, |
Owner
There was a problem hiding this comment.
Suggested change
| n_results: Optional[int] = None, | |
| n_results: Optional[int] = 5, |
let's keep 5 as the default in case the user does not specify a number
| "Use the available tools to search for papers, analyze topics, and understand trends. " | ||
| "Present the information in a clear, easy-to-understand format. " | ||
| f"Today's date is {datetime.now().strftime('%Y-%m-%d')}. " | ||
| "When the user requests a specific number of papers, pass that number as n_results " |
Owner
There was a problem hiding this comment.
these instructions should not be in the base instructions but rather in the prompt for the search_papers mcp tool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #369