Skip to content

refactor: Remove automatic push after commit#81

Open
karlssonkennneth wants to merge 1 commit intothe-cafe:mainfrom
karlssonkennneth:remove_automatic_push
Open

refactor: Remove automatic push after commit#81
karlssonkennneth wants to merge 1 commit intothe-cafe:mainfrom
karlssonkennneth:remove_automatic_push

Conversation

@karlssonkennneth
Copy link
Copy Markdown

Commit and push serve two different purposes. Commit creates a local history while push shares your changes. Users might want to amend the commit, or review it before pushing.

There are also different tools used for pushing the code. At companies using Gerrit, the git-review tool is commonly used for pushing the code.
https://docs.opendev.org/opendev/git-review/latest/index.html

Description

Test Plan

Commit and push serve two different purposes. Commit creates a
local history while push shares your changes. Users might want to amend
the commit, or review it before pushing.

There are also different tools used for pushing the code. At companies
using Gerrit, the git-review tool is commonly used for
pushing the code.
https://docs.opendev.org/opendev/git-review/latest/index.html
Copy link
Copy Markdown
Collaborator

@Seif-Mamdouh Seif-Mamdouh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @karlssonkennneth!

Thank you for your contribution 🎉

While this actually makes sense, I do think that committing and pushing is more like a custom thing we decided to do, so maybe you can add a command that only commits the message without pushing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants