Create e-commerce Web API by basemkasem · Pull Request #96 · the-csharp-academy/CodeReviews.Console.EcommerceApi

basemkasem · 2026-03-31T20:54:54Z

No description provided.

Fix UnitOfWork performance issue or creating a new object each time needed in a request.

Update "delete" logic in GenericRepository

…lAsync and GetByIdAsync

# This is the 1st commit message: Add pagination support to GetAllAsync and include properties to GetAllAsync and GetByIdAsync # The commit message the-csharp-academy#2 will be skipped: # fixup! Add pagination support to GetAllAsync and include properties to GetAllAsync and GetByIdAsync

Fix category including property to product. Fix a repository method to be async

…n and include properties.

…nd CreateSale business logic.

…d set accessors for better type safety.

…o assign the parameter from query string

…e quantity.

…stock scenario.

Added detailed documentation for the E-commerce API, including features, architecture, technologies, installation instructions, API endpoints, usage examples, and future enhancements.

Removed contributing guidelines and license section.

…oller to use FluentValidation for validation.

… names and error messages in ProductController

…troller to use FluentValidation for validation.

…aleItem DTOs

Created input validation and exception handling from the future enhancements section and added to the features section.

Updated exception handling and input validation sections for clarity and consistency.

Updated README to reflect API versioning and added FluentValidation details.

Updated the status of the authentication & authorization task to indicate it is currently in progress.

chrisjamiecarter

Hey @basemkasem 👋,

Excellent work on your E-commerce API project submission 🎉!

I have performed a peer review. Review/ignore any comments as you wish.

Your code demonstrates a solid understanding of Clean Architecture with excellent separation of concerns across Core, Data, Services, and Web layers. The implementation includes sophisticated features like the Result pattern for error handling, FluentValidation for input validation, API versioning, soft delete pattern, and pagination support. The build succeeds and the code structure is well-organized.

🟠 Project Submission

💡 Please place all your code inside a single top-level folder named: [ProjectName].[UserName].

👨‍🏫 Example: EcommerceApi.basemkasem

📁 CodeReviews.Console.EcommerceApi ⬅️ Forked repo
 ┣ 📄 .codacy.yml
 ┣ 📄 .gitignore
 ┣ 📁 EcommerceApi.basemkasem ❗ Should be this
 ┃  ┗ 📄 Project.sln ✅
 ┃  ┗ 📄 README.md ❗Should be here not root
 ┃  ┗ 📁 EcommerceApi.Core ✅
 ┃  ┗ 📁 EcommerceApi.Data ✅
 ┃  ┗ 📁 EcommerceApi.Service ✅
 ┃  ┗ 📁 EcommerceApi.Web ✅

💭 This helps me clearly identify your work and confirms you can work within community repository guidelines.

I will go ahead and mark as approved, keep up the excellent work on the next projects! 😊

Best regards,
@chrisjamiecarter 👍

chrisjamiecarter · 2026-04-06T19:23:53Z

EcommerceApi/Ecommerce.Core/DTOs/Category/CategoryDto.cs

@@ -0,0 +1,8 @@
+namespace Ecommerce.Core.DTOs.Category;
+
+public class CategoryDto


🟡 Class vs Record

💭 Nothing wrong here, just think of the benefits of using a record here instead of a class.

chrisjamiecarter · 2026-04-06T19:28:23Z

EcommerceApi/Ecommerce.Core/Interfaces/Repositories/IGenericRepository.cs

+
+namespace Ecommerce.Core.Interfaces.Repositories;
+
+public interface IGenericRepository<T> where T : class


🔵 Generic Repositories

❓ Interesting, did you implement generic repositories for learning, or do you actually prefer using them?

chrisjamiecarter · 2026-04-06T19:32:13Z

EcommerceApi/Ecommerce.Core/Interfaces/Repositories/IUnitOfWork.cs

+
+namespace Ecommerce.Core.Interfaces.Repositories;
+
+public interface IUnitOfWork


🔵 Unit of Work

❓ I know you have implemented CA and app should not know about infra, but should unit of work be defined here as a contract? Also as you are using EFCore in Infra, that already implements the UoW pattern, so is kind of pointless.

chrisjamiecarter · 2026-04-06T19:41:44Z

EcommerceApi/Ecommerce.Core/Validators/Categories/CreateCategoryDtoValidator.cs

+        RuleFor(x => x.Name)
+            .NotEmpty()
+            .WithMessage("Category name is required.")
+            .MaximumLength(50)


🟡 Magic Numbers

💡 Move magic numbers like this into the entity, so the single source of truth lives there instead of every single validator.

chrisjamiecarter · 2026-04-06T19:55:22Z

EcommerceApi/Ecommerce.Data/AppDbContext.cs

+    public DbSet<SaleItem> SaleItems { get; set; }
+
+
+    protected override void OnModelCreating(ModelBuilder modelBuilder)


🟡 Configuration Classes

💡 Consider creating configuration classes for your entities and holding this information there instead of here in AppDbContext, then applying by calling modelBuilder.ApplyConfigurationsFromAssembly; instead.

chrisjamiecarter · 2026-04-06T19:59:48Z

EcommerceApi/Ecommerce.Web/Program.cs

+
+app.MapControllers();
+
+app.Run();


🟠 Missing Database Initialization

💡 The application doesn't initialize the database on startup. I would recommend for C# academy project submissions you add EnsureCreated or Migrate to ensure the database is created/migrated. I know your README covers this, but one of your jobs is to make it as frictionless for the reviewer as possible.

chrisjamiecarter · 2026-04-06T20:01:49Z

EcommerceApi/Ecommerce.Web/appsettings.json

+    }
+  },
+  "AllowedHosts": "*"
+}


🟠 Missing Connection String

💡 Again, I know this is covered in the README, but the appsettings.json is missing the required "ConnectionStrings" section. You should at least have a dummy/placeholder value in here. I assume you are using user secrets for the actual connection string on your machine which is best practice.

chrisjamiecarter · 2026-04-06T20:06:46Z

EcommerceApi/Ecommerce.Services/ProductService.cs

+            Price = product.Price,
+            CategoryId = product.CategoryId
+        };
+        if(newProduct.Quantity <= 0)


🟠 Domain Concern

💡 This logic is probably a Domain rule and should be on the entity. Also would be true for Quantity == 0 which is not negative like the fail message suggests.

chrisjamiecarter · 2026-04-06T20:07:22Z

EcommerceApi/Ecommerce.Services/ProductService.cs

+        int rowsAffected = await _unitOfWork.CompleteAsync();
+        if (rowsAffected == 0)
+        {
+            return Result<ProductDto>.Fail("Failed to create category");


🟡 Error Message References Wrong Entity

💡 When creation fails, the error message says "Failed to create category" but it's actually creating a Product. This should say "Failed to create product".

basemkasem and others added 30 commits February 19, 2026 17:26

create basic structure

4cd5b4c

Create base entities and DbContext with migrations

f3071a4

Create UnitOfWork and Repositories Interfaces and Implementations

99475dd

Apply soft delete feature

867c034

Inject UnitOfWork to DI Container.

c77f4ce

Fix UnitOfWork performance issue or creating a new object each time needed in a request.

Create a general response class to return for each service

ef660f4

Apply ISoftDeletable interface.

95637bd

Update "delete" logic in GenericRepository

Add Category Module(DTOs, Service, Controller)

ef30dfe

fix update category logic

2a068e4

Add pagination support to GetAllAsync and include properties to GetAl…

c7f788d

…lAsync and GetByIdAsync

Move Result<T> to Utilities folder and update references

5d0f861

Move Result<T> to Utilities folder and update references

89df08a

Create Product Module(Controller,Service, DTOs)

5ca2f5c

Merge remote-tracking branch 'origin/main'

32be35e

Add Product Service to DI Container.

ded8d39

Fix category including property to product. Fix a repository method to be async

Add quntity attribute to product table

7b0751c

fix page number issue when entered less than 1

963bb4c

Add Find method to IGenericRepository to support querying by conditio…

480fe77

…n and include properties.

Create Sale DTOs, Interface, and register ISaleService in DI Container.

b33be1e

Create Sale DTOs, Interface, register ISaleService in DI Container, a…

779f9dc

…nd CreateSale business logic.

Merge remote-tracking branch 'origin/main'

fd70152

Update collection navigation properties not to be nullable and change…

f4eec04

…d set accessors for better type safety.

Create SaleController, add SaleService get methods

af2fe3e

fix empty salesDto list in GetAllSalesAsync, update GetAll endpoint t…

92eaf59

…o assign the parameter from query string

Fix quantity assigned to default value and add validation for negativ…

62c8da7

…e quantity.

Fix quantity validation for sale item quantity was not handling zero …

8e09dc7

…stock scenario.

Add README.md for E-commerce API documentation

9a3ed5b

Added detailed documentation for the E-commerce API, including features, architecture, technologies, installation instructions, API endpoints, usage examples, and future enhancements.

Add Postman collection json file

0f6c64f

Merge remote-tracking branch 'origin/main'

1803daa

basemkasem and others added 20 commits March 27, 2026 06:30

Update README

a6d9433

Removed contributing guidelines and license section.

Add validation to CreateProductDto and UpdateProductDto, update contr…

5df25cd

…oller to use FluentValidation for validation.

Merge remote-tracking branch 'origin/main'

5ec82e9

fix quantity validation incorrect check in ProductService

2010954

fix unnecessary repeatitve validation in the same assembly assignment

cf97492

Enhance error message format in validation errors to include property…

26ff99c

… names and error messages in ProductController

Add validation to CreateCategoryDto and UpdateCategoryDto, update con…

cd1d3cc

…troller to use FluentValidation for validation.

Change names of validators to match DTOs

2250178

Create CreateSaleDtoValidator and Add FluentValidation for Sale and S…

833f12b

…aleItem DTOs

Apply global exception handling

fe1ebc8

fix production error handling and add safe error messages

b9087c5

update postman collection

5fe7a34

Implement input validation and exception handling features

5ba1eb3

Created input validation and exception handling from the future enhancements section and added to the features section.

Update API URL and task list in README.md

fb9e8e1

Revise exception handling and input validation details

c87f47e

Updated exception handling and input validation sections for clarity and consistency.

Add Api Versioning Feature

86df173

Merge remote-tracking branch 'origin/main'

59d6ceb

Update urls to have apiVersion Variable

a21fe01

Enhance README with API versioning feature

e51adde

Updated README to reflect API versioning and added FluentValidation details.

Mark authentication & authorization task as in progress

1b62a7f

Updated the status of the authentication & authorization task to indicate it is currently in progress.

chrisjamiecarter approved these changes Apr 6, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create e-commerce Web API#96

Create e-commerce Web API#96
basemkasem wants to merge 50 commits intothe-csharp-academy:mainfrom
basemkasem:main

basemkasem commented Mar 31, 2026

Uh oh!

chrisjamiecarter left a comment

Uh oh!

chrisjamiecarter Apr 6, 2026

Uh oh!

chrisjamiecarter Apr 6, 2026

Uh oh!

chrisjamiecarter Apr 6, 2026

Uh oh!

chrisjamiecarter Apr 6, 2026

Uh oh!

chrisjamiecarter Apr 6, 2026

Uh oh!

chrisjamiecarter Apr 6, 2026

Uh oh!

chrisjamiecarter Apr 6, 2026

Uh oh!

chrisjamiecarter Apr 6, 2026

Uh oh!

chrisjamiecarter Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,8 @@
		namespace Ecommerce.Core.DTOs.Category;

		public class CategoryDto


		namespace Ecommerce.Core.Interfaces.Repositories;

		public interface IGenericRepository<T> where T : class


		namespace Ecommerce.Core.Interfaces.Repositories;

		public interface IUnitOfWork

		public DbSet<SaleItem> SaleItems { get; set; }


		protected override void OnModelCreating(ModelBuilder modelBuilder)


		app.MapControllers();

		app.Run(); No newline at end of file

Conversation

basemkasem commented Mar 31, 2026

Uh oh!

chrisjamiecarter left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants