fix(validate): escape regex quantifiers in Sage sequence parsing#392
Merged
theGreatHerrLebert merged 1 commit intomainfrom Feb 18, 2026
Merged
fix(validate): escape regex quantifiers in Sage sequence parsing#392theGreatHerrLebert merged 1 commit intomainfrom
theGreatHerrLebert merged 1 commit intomainfrom
Conversation
The + and - signs inside bracket patterns were not escaped, causing them to be interpreted as regex quantifiers instead of literal characters. This meant none of the Sage mass annotations (e.g. [+57.021465]) were being converted to UNIMOD format, inflating false positive counts by ~10K per run. Also corrected mass prefixes for acetyl (42.0106 -> 42.0105) and water loss (-18.0106 -> -18.0105). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The + and - signs inside bracket patterns were not escaped, causing them to be interpreted as regex quantifiers instead of literal characters. This meant none of the Sage mass annotations (e.g. [+57.021465]) were being converted to UNIMOD format, inflating false positive counts by ~10K per run. Also corrected mass prefixes for acetyl (42.0106 -> 42.0105) and water loss (-18.0106 -> -18.0105).