Fixes #39275 - prevent global override of radio position#10967
Merged
Conversation
Member
|
Not looking at the actual commit, but on the process:
You can't use Refs on a closed issue because it'll never show up in the release notes. The bot doesn't check for it, but you should open a new bug. Also, a typo in position there. |
MariaAga
force-pushed
the
radio-position-css
branch
from
e82423c to
86fbf8b
Compare
Member
Author
|
@ekohl Thanks, fixed! |
jeremylenz
approved these changes
Apr 29, 2026
Contributor
jeremylenz
left a comment
jeremylenz
left a comment
There was a problem hiding this comment.
PR title still needs an update. Should probably be "Fixes" since it's a new bug now, but not blocking.
thanks for finding and fixing 🙂
MariaAga
force-pushed
the
radio-position-css
branch
from
86fbf8b to
712a91b
Compare
MariaAga
changed the title
Member
Author
|
Updated the commit and title, thanks 🙏 |
Contributor
|
@MariaAga Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10591
Added a global rule to all PF5 radio inputs. This makes all radio inputs position change, and sometimes be in a completely different place than they should.
custom CSS rules should be specific to the component.
https://theforeman.org/handbook.html