Fixes #39299 - Add additive fact import mode#10980
Open
pablomh wants to merge 1 commit into
Open
Conversation
Add additive: keyword argument to FactImporter#import! and HostFactImporter#import_facts. When true, existing facts not in the new set are preserved (delete_removed_facts is skipped). This enables importing a subset of facts without wiping facts from other sources, needed by Katello (katello#11701) to import only OS-detection facts at registration time. Initialize fact import counters with explicit defaults to prevent nil arithmetic errors when import methods are called independently. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pablomh
force-pushed
the
registration/additive-fact-import
branch
from
37a296e to
83d64e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
additive:keyword argument toFactImporter#import!andHostFactImporter#import_facts. Whentrue, existing facts not in the new set are preserved (delete_removed_factsis skipped).This enables importing a subset of facts without wiping facts from other sources, needed by Katello (katello#11701) to import only OS-detection facts at registration time.
Changes
fact_importer.rb:import!(additive: false)— skipsdelete_removed_factswhen truehost_fact_importer.rb:import_facts(facts, source_proxy = nil, additive: false)— passes throughHow to test
bundle exec rake test TEST=test/unit/fact_importer_test.rbbundle exec rake test TEST=test/unit/host_fact_importer_test.rb