Fixes #39261 - Pin theforeman-rubocop in Gemfile only#187
Merged
stejskalleos merged 1 commit intotheforeman:masterfrom Apr 29, 2026
Merged
Fixes #39261 - Pin theforeman-rubocop in Gemfile only#187stejskalleos merged 1 commit intotheforeman:masterfrom
stejskalleos merged 1 commit intotheforeman:masterfrom
Conversation
|
|
||
| s.required_ruby_version = '>= 2.7', '< 4' | ||
|
|
||
| s.add_development_dependency 'theforeman-rubocop' |
Collaborator
There was a problem hiding this comment.
I'm not against the change, but what's the reasoning here?
Is this causing an issue, or is it just a best practice?
Member
Author
There was a problem hiding this comment.
Ehh, sorry I didn't write it here as well, but the idea is here:
stejskalleos
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.