Fixes #72 - Replace sidekiq-selinux wrapper with direct sidekiq call#429
Open
jakduch wants to merge 1 commit intotheforeman:masterfrom
Open
Fixes #72 - Replace sidekiq-selinux wrapper with direct sidekiq call#429jakduch wants to merge 1 commit intotheforeman:masterfrom
jakduch wants to merge 1 commit intotheforeman:masterfrom
Conversation
…ekiq call The sidekiq-selinux wrapper script exists only for SELinux domain transition on bare-metal RPM installations. In containers, SELinux is disabled (label=disable) so the wrapper adds no value. Replace the wrapper call with a direct sidekiq invocation and use an absolute path for the dynflow-sidekiq.rb script instead of a relative one for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sidekiq-selinux wrapper at /usr/libexec/foreman/sidekiq-selinux is a packaging artifact that only exists for SELinux domain transition on bare-metal RPM installations. Its entire content is:
In containers where SELinux is disabled (label=disable), this wrapper serves no purpose. This replaces the wrapper call with a direct sidekiq invocation and uses an absolute path for the dynflow-sidekiq.rb script.
Based on the discussion in evgeni/talks#4 (comment)
cc @ekohl @evgeni