Fixes #38927 - Drop async-ssh#128
Merged
ofedoren merged 1 commit intotheforeman:masterfrom Nov 28, 2025
Merged
Conversation
adamruzicka
force-pushed
the
no-async-ssh
branch
from
dcdb990 to
7082ce5
Compare
This was referenced Nov 26, 2025
ofedoren
reviewed
Nov 27, 2025
Member
ofedoren
left a comment
ofedoren
left a comment
There was a problem hiding this comment.
Seems like it's ready, is there something missing to undraft it?
Also, given that there doesn't seem to be an easy way to migrate to a different mode, this will probably require a big red release note.
adamruzicka
force-pushed
the
no-async-ssh
branch
from
7082ce5 to
29acff1
Compare
Contributor
Author
Not anymore, I wanted to get the whole set of PRs ready first |
Contributor
Author
And also a big version bump, maybe even up to 1.0.0 |
ofedoren
approved these changes
Nov 27, 2025
Member
ofedoren
left a comment
ofedoren
left a comment
There was a problem hiding this comment.
Ah, I guess a RM issue linked would be nice to have though. Otherwise ACK.
Contributor
Author
|
🍏 |
ofedoren
approved these changes
Nov 28, 2025
Member
ofedoren
left a comment
ofedoren
left a comment
There was a problem hiding this comment.
Thanks, @adamruzicka, let's get this in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.