Fixes #32971 - Do not enable by default#59
Closed
ekohl wants to merge 1 commit intotheforeman:masterfrom
Closed
Conversation
Currently the example config file contains enabled: true which means yum install is sufficient to enable it. However, you must also create a key. All plugins are disabled by default and this follow that. What's worse, true means both HTTP and HTTPS which can also be less secure.
Member
Author
|
Ok, maybe it was wrong fro my side: $ grep enabled: smart_proxy_*/settings.d/*.*
smart_proxy_ansible/settings.d/ansible.yml.example::enabled: true
smart_proxy_container_gateway/settings.d/container_gateway.yml.example::enabled: true
smart_proxy_dynflow/settings.d/dynflow.yml.example::enabled: true
smart_proxy_host_reports/settings.d/host_reports.yml.example::enabled: true
smart_proxy_ipam/settings.d/externalipam.yml.example::enabled: true
smart_proxy_monitoring/settings.d/monitoring_icinga2.yml.example::enabled: true
smart_proxy_monitoring/settings.d/monitoring_icingadirector.yml.example::enabled: true
smart_proxy_monitoring/settings.d/monitoring.yml.example::enabled: true
smart_proxy_omaha/settings.d/omaha.yml.example::enabled: true
smart_proxy_openscap/settings.d/openscap.yml.example::enabled: true
smart_proxy_pulp/settings.d/pulpcore.yml.example::enabled: true
smart_proxy_remote_execution_ssh/settings.d/remote_execution_ssh.yml.example::enabled: false
smart_proxy_salt/settings.d/salt.yml.example::enabled: true
smart_proxy_shellhooks/settings.d/shellhooks.yml.example:#:enabled: https
smart_proxy_shellhooks/settings.d/shellhooks.yml.example::enabled: false
smart_proxy_vault/settings.d/vault.yml.example::enabled: true |
ehelms
approved these changes
Jul 9, 2021
Member
|
@adamruzicka What do you want to do here? Make this change or keep it the way it seems most plugins are? |
Contributor
|
I'd like to stay consistent with other plugins |
Member
Author
|
Given most actually default to true, I'm closing this. Let's finish up #57 so it at least fails fast when it's not configured. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the example config file contains enabled: true which means yum install is sufficient to enable it. However, you must also create a key. All plugins are disabled by default and this follow that.
What's worse, true means both HTTP and HTTPS which can also be less secure.