Skip to content

Fix eslint command to run on all files#3

Open
slaweet wants to merge 1 commit into
thefrontside:masterfrom
slaweet:patch-1
Open

Fix eslint command to run on all files#3
slaweet wants to merge 1 commit into
thefrontside:masterfrom
slaweet:patch-1

Conversation

@slaweet

@slaweet slaweet commented Oct 31, 2019

Copy link
Copy Markdown

What was the problem?

The eslint command didnt specify which files to run on, so it never checked anything and always passed with usage info:

#!/bin/bash -eo pipefail
yarn eslint --max-warnings=0 --format junit --output-file ./reports/eslint/eslint.xml
yarn run v1.19.1
$ /home/circleci/project/node_modules/.bin/eslint --max-warnings=0 --format junit --output-file ./reports/eslint/eslint.xml
eslint [options] file.js [file.js] [dir]

See: https://circleci.com/gh/slaweet/github-commit-punch-chart/194

How did I fix it?

By telling eslint to run on all files in the repo (.)

How did I test it?

I tested it only by running the command locally in my repo, so I'm not sure if this is needed for everyone. Let me know what do you think 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant