This repository was archived by the owner on Nov 3, 2020. It is now read-only.
Created short deployment for test cases#99
Draft
thrilok209 wants to merge 11 commits intothehubbleproject:masterfrom
Draft
Created short deployment for test cases#99thrilok209 wants to merge 11 commits intothehubbleproject:masterfrom
thrilok209 wants to merge 11 commits intothehubbleproject:masterfrom
Conversation
Contributor
ChihChengLiang
left a comment
ChihChengLiang
left a comment
There was a problem hiding this comment.
Great works on exploring this, I left some comments while reading it.
scripts/helpers/migration.ts
Outdated
| libs: any, | ||
| params?: any | ||
| ) { | ||
| return await new Promise(async (resolve, reject) => { |
Contributor
There was a problem hiding this comment.
What's the purpose for all these await new Promise(async?
Instead of wrapping them in a promise and use a resolve callback, why we can't just return the updatedInstance at the end?
Collaborator
Author
There was a problem hiding this comment.
While using fs.readFile() the function had some issue while returning updatedInstance . So, I used promises.
| export async function getRollupUtils(rollupUtilsInstance?: any) { | ||
| var rollupUtils: any = !rollupUtilsInstance | ||
| ? await rollupUtils.deployed() | ||
| : rollupUtilsInstance; |
Contributor
There was a problem hiding this comment.
Can we wrap these checks in a function?
Collaborator
Author
There was a problem hiding this comment.
Might have to create 3-4 functions for different contracts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.