Skip to content

chore: remove wasm-pack install step#1045

Merged
ryardley merged 2 commits into
mainfrom
ci/no-wasm-pack-install
Nov 24, 2025
Merged

chore: remove wasm-pack install step#1045
ryardley merged 2 commits into
mainfrom
ci/no-wasm-pack-install

Conversation

@cedoor

@cedoor cedoor commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

Closes #1047

Summary by CodeRabbit

  • Chores
    • Streamlined CI/CD workflows by optimizing installation steps across continuous integration and npm release pipelines.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel

vercel Bot commented Nov 24, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
crisp Ready Ready Preview Comment Nov 24, 2025 5:43pm
enclave-docs Ready Ready Preview Comment Nov 24, 2025 5:43pm

@coderabbitai

coderabbitai Bot commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

The pull request removes the "Install wasm-pack" steps from CI and release workflows across two files. This change reflects that wasm-pack is now provisioned as a JavaScript package dependency, allowing pnpm install to handle its installation automatically rather than through explicit workflow steps.

Changes

Cohort / File(s) Change Summary
GitHub Actions Workflows
​.github/workflows/ci.yml, ​.github/workflows/releases.yml
Removed "Install wasm-pack" steps from CI and release jobs, eliminating manual wasm-pack installation since it is now included as a package.json dependency

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Verify that wasm-pack is declared as a devDependency in the relevant package.json files
  • Confirm that subsequent workflow steps that depend on wasm-pack will function correctly when it's installed via pnpm install

Possibly related PRs

Suggested reviewers

  • ryardley
  • 0xjei

Poem

🐰 Pack it light, pack it tight,
No more install steps in the night!
Dependencies flow from package's embrace,
Wasm-pack finds its rightful place. ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing wasm-pack install steps from CI workflows as specified in issue #1047.
Linked Issues check ✅ Passed The PR successfully removes wasm-pack installation steps from CI workflows (.github/workflows/ci.yml and .github/workflows/releases.yml) as required by issue #1047 [#1047].
Out of Scope Changes check ✅ Passed All changes in the PR are directly related to removing wasm-pack installation steps from CI workflows, with no unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/no-wasm-pack-install

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f7fd8c9 and 4615349.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml (0 hunks)
  • .github/workflows/releases.yml (0 hunks)
💤 Files with no reviewable changes (2)
  • .github/workflows/ci.yml
  • .github/workflows/releases.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cedoor cedoor changed the title ci: remove wasm-pack install step chore: remove wasm-pack install step Nov 24, 2025
@cedoor cedoor marked this pull request as ready for review November 24, 2025 13:38

@ryardley ryardley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@ryardley ryardley enabled auto-merge (squash) November 24, 2025 17:42
@ryardley ryardley merged commit 17cd488 into main Nov 24, 2025
23 checks passed
@github-actions github-actions Bot deleted the ci/no-wasm-pack-install branch December 2, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove wasm-pack installation step

2 participants