Skip to content

feat: verify external contracts#1106

Merged
ctrlc03 merged 1 commit into
mainfrom
feat/verify-external-libs
Dec 16, 2025
Merged

feat: verify external contracts#1106
ctrlc03 merged 1 commit into
mainfrom
feat/verify-external-libs

Conversation

@ctrlc03

@ctrlc03 ctrlc03 commented Dec 14, 2025

Copy link
Copy Markdown
Collaborator

verify external contracts. now we can verify enclave contracts from crisp all in one go

Summary by CodeRabbit

  • Bug Fixes
    • Contract verification now correctly recognizes and processes external package contracts by normalizing their paths, returning fully-qualified contract names instead of skipping them, and providing clearer log messages about found external contracts.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel

vercel Bot commented Dec 14, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Review Updated (UTC)
crisp Skipped Skipped Dec 16, 2025 9:38am
enclave-docs Skipped Skipped Dec 16, 2025 9:38am

@coderabbitai

coderabbitai Bot commented Dec 14, 2025

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@cedoor has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 39 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 4b36faf and 5547fd0.

📒 Files selected for processing (1)
  • packages/enclave-contracts/scripts/verify.ts (1 hunks)

Walkthrough

The verification script's contract lookup was changed to normalize artifact source paths (strip leading "./") and treat external packages (paths starting with "./@", "@", or containing "node_modules") as valid artifacts by returning a normalized fully-qualified name ":" instead of skipping them.

Changes

Cohort / File(s) Summary
Contract verification logic
packages/enclave-contracts/scripts/verify.ts
Normalize sourceName (remove leading "./"), detect external sources ("./@", "@", or containing "node_modules"), log found external contracts with the normalized path, and return fully-qualified names using the unified normalizedPath for both external and local artifacts; JSON parse error handling retained.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify path-normalization covers edge cases (leading dots, nested node_modules, scoped packages).
  • Confirm downstream consumers accept the ":" format.

Possibly related PRs

Poem

🐰 I hopped through paths both near and far,

I trimmed the dots and found each star,
External friends I no longer shun,
Now qualified names shine like sun,
Hop—contracts found, the job is done! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: verify external contracts' clearly and concisely summarizes the main change: adding verification support for external contracts, which aligns with the raw summary and PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ctrlc03 ctrlc03 requested review from 0xjei and cedoor December 15, 2025 08:46

@0xjei 0xjei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ctrlc03 ctrlc03 enabled auto-merge (squash) December 16, 2025 09:13
@cedoor cedoor force-pushed the feat/verify-external-libs branch from 66c46e8 to 4b36faf Compare December 16, 2025 09:17
@vercel vercel Bot temporarily deployed to Preview – enclave-docs December 16, 2025 09:17 Inactive
@vercel vercel Bot temporarily deployed to Preview – crisp December 16, 2025 09:17 Inactive
@cedoor cedoor force-pushed the feat/verify-external-libs branch from 4b36faf to 5547fd0 Compare December 16, 2025 09:37
@vercel vercel Bot temporarily deployed to Preview – enclave-docs December 16, 2025 09:38 Inactive
@vercel vercel Bot temporarily deployed to Preview – crisp December 16, 2025 09:38 Inactive
@ctrlc03 ctrlc03 merged commit 70913fd into main Dec 16, 2025
24 checks passed
@github-actions github-actions Bot deleted the feat/verify-external-libs branch December 24, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants