Skip to content

chore: update versions download link#1275

Merged
hmzakhalid merged 6 commits into
mainfrom
chore/update-versions-link
Feb 10, 2026
Merged

chore: update versions download link#1275
hmzakhalid merged 6 commits into
mainfrom
chore/update-versions-link

Conversation

@hmzakhalid

@hmzakhalid hmzakhalid commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores

    • Switched the version manifest source to the main repository branch for stable version information retrieval.
  • Bug Fixes

    • Improved error routing for compute failures so processing can continue without blocking on a missing proof.
  • Improvements

    • Enhanced observability and richer error reporting in client worker and SDK code, and strengthened network/fetch error handling with clearer messages.
  • Tests

    • Adjusted test runner launch options to enable shared memory and relax web-security for test execution.

@vercel

vercel Bot commented Feb 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
crisp Ready Ready Preview, Comment Feb 10, 2026 2:10pm
enclave-docs Ready Ready Preview, Comment Feb 10, 2026 2:10pm

Request Review

@coderabbitai

coderabbitai Bot commented Feb 9, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Updated a manifest URL to main; changed multithread error publishing to broadcast ComputeRequestError; adjusted an inline comment in proof actor; added debug/error logging in CRISP proof worker; strengthened fetch error handling in CRISP SDK state; and added Chromium launch options in Playwright config.

Changes

Cohort / File(s) Summary
Prover configuration
crates/zk-prover/src/config.rs
Updated VERSIONS_MANIFEST_URL to point at the main branch manifest URL (value change only).
Multithread compute handling
crates/multithread/src/multithread.rs
On compute failure, publish the error via bus.publish(e) (a ComputeRequestError) instead of bus.err(EType::Computation, e), so other actors can receive/handle it. Review error type routing and consumers.
Proof request actor comment
crates/zk-prover/src/actors/proof_request.rs
Inline comment updated to reference proof field for validation status (no logic change).
CRISP worker logs & error reporting
examples/CRISP/client/libs/crispSDKWorker.js
Added debug logs at several proof-generation steps and richer error reporting (detailed errorMessage posted back). Check logging noise and error payloads.
CRISP SDK fetch/error handling
examples/CRISP/packages/crisp-sdk/src/state.ts
Replaced direct fetch calls with URL vars, added try/catch, explicit response.ok checks, and improved error messages including endpoint and status. Verify upstream callers expect same errors.
Playwright launch options
examples/CRISP/playwright.config.ts
Added Chromium launchOptions args: --enable-features=SharedArrayBuffer and --disable-web-security. Review test isolation and security implications for CI.

Sequence Diagram(s)

mermaid
sequenceDiagram
autonumber
actor Client as Client
participant Multithread as MultithreadWorker
participant Bus as EventBus
participant ProofActor as ProofRequestActor

Client->>Multithread: submit ComputeRequest
Multithread->>Multithread: process request
alt success
    Multithread->>Bus: publish(ComputationResult)
    Bus->>ProofActor: route(ComputationResult)
    ProofActor->>Client: respond(with proof)
else error
    Multithread->>Bus: publish(ComputeRequestError)
    Bus->>ProofActor: route(ComputeRequestError)
    ProofActor->>Client: respond(continue without proof / handle error)
end
Note right of Bus: style Bus fill:rgba(141,211,199,0.5),stroke:rgba(0,0,0,0.5),stroke-width:1px

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • ctrlc03
  • ryardley
  • cedoor

Poem

🐰 I hop through code with tiny paws and cheer,
The manifest now lives where main is near,
Errors hop on buses to find who’ll mend,
Logs sing loud so debuggers comprehend,
I nibble carrots, then twitch — commits appear! 🥕

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title focuses on updating the versions download link, but the changeset includes multiple unrelated modifications across logging, error handling, and test configurations. The title should reflect all significant changes in the PR, or the scope should be narrowed. Consider: 'chore: update versions link and enhance error handling/logging' or revert unrelated changes to separate PRs.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/update-versions-link

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
examples/CRISP/client/libs/crispSDKWorker.js (1)

70-70: Minor: trailing newline when stack is absent.

When error.stack is undefined, this produces "ErrorName: message\n" with a trailing newline. Consider omitting the newline when there's no stack.

Suggested fix
-        const errorMessage = error instanceof Error ? `${error.name}: ${error.message}\n${error.stack || ''}` : String(error)
+        const errorMessage = error instanceof Error ? `${error.name}: ${error.message}${error.stack ? '\n' + error.stack : ''}` : String(error)
examples/CRISP/packages/crisp-sdk/src/state.ts (1)

19-36: Consider extracting a shared fetch helper to reduce repetition.

All three functions follow the identical pattern: build URL → try/catch fetch → check response.ok → throw with status. A small helper like postJson(url, body, operationName) would consolidate this into one place and make future changes (e.g., adding timeouts or retries) easier.

Example helper
async function postJson(url: string, body: unknown, operation: string): Promise<Response> {
  let response: Response
  try {
    response = await fetch(url, {
      method: 'POST',
      headers: { 'Content-Type': 'application/json' },
      body: JSON.stringify(body),
    })
  } catch (error) {
    throw new Error(`Failed to ${operation} from ${url}: ${error instanceof Error ? error.message : String(error)}`)
  }
  if (!response.ok) {
    throw new Error(`Failed to ${operation}: ${response.status} ${response.statusText}`)
  }
  return response
}

Then each function simplifies to:

const response = await postJson(url, { round_id: e3Id }, 'fetch round details')

Also applies to: 80-96, 112-128


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

ctrlc03
ctrlc03 previously approved these changes Feb 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the zk-prover’s remote versions manifest URL to stop using a feature-branch raw GitHub link and instead reference the default branch.

Changes:

  • Remove temporary TODO referencing the feature branch.
  • Update VERSIONS_MANIFEST_URL to fetch versions.json from gnosisguild/enclave on main.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/zk-prover/src/config.rs
cedoor
cedoor previously approved these changes Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants