Skip to content

fix: update bb.js URL as a tmp fix for crisp e2e tests#1298

Merged
cedoor merged 10 commits into
mainfrom
fix/crisp-e2e
Feb 11, 2026
Merged

fix: update bb.js URL as a tmp fix for crisp e2e tests#1298
cedoor merged 10 commits into
mainfrom
fix/crisp-e2e

Conversation

@cedoor

@cedoor cedoor commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

Re #1299

Summary by CodeRabbit

  • Chores

    • Switched CRS/data fetch endpoints to CDN-hosted URLs.
    • Added local patch mapping for a dependency and package manager metadata in docs.
  • Style

    • Reformatted dynamic imports to a more compact form.
    • Removed Prettier integration from linting configuration.
  • Other

    • Example env default E3_DURATION increased from 70 to 100.
    • Example contract license header changed to LGPL-3.0-only.
    • Public contract API updated: onCommitteePublished now accepts an additional bytes32 parameter (ABI updated).

@cedoor cedoor requested a review from ctrlc03 February 11, 2026 08:53
@vercel

vercel Bot commented Feb 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
crisp Ready Ready Preview, Comment Feb 11, 2026 0:17am
enclave-docs Ready Ready Preview, Comment Feb 11, 2026 0:17am

Request Review

@coderabbitai

coderabbitai Bot commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Updates CRS fetch endpoints to a CDN in a patched bundle and TypeScript source, registers that patch in pnpm config, removes Prettier from solhint, changes a CRISP contract license header, adjusts an env example value, compacts several dynamic import statements, and adds a new committeePublicKeyHash parameter to Enclave-related interfaces and cross-contract calls.

Changes

Cohort / File(s) Summary
Patched bundle (CDN URLs)
examples/CRISP/patches/@aztec__bb.js@3.0.0-nightly.20251104.patch
Replaces https://crs.aztec.network/... URLs with https://crs.aztec-cdn.foundation/... in the patched compiled bundle.
CRS TypeScript source
packages/.../src/crs/net_crs.ts, packages/.../dest/browser/crs/net_crs.js
Mirrors CDN URL substitutions for g1.dat, g2.dat, and grumpkin files; retains Range headers and retry/backoff behavior.
Package patch registration
package.json
Adds pnpm.patchedDependencies entry mapping @aztec/bb.js@3.0.0-nightly.20251104 → patch file path.
Solhint config cleanup
packages/enclave-contracts/.solhint.json
Removes Prettier plugin and prettier/prettier rule.
License header change
examples/CRISP/packages/crisp-contracts/contracts/CRISPVerifier.sol
Changes license header to LGPL-3.0-only and adds warranty disclaimer; no code logic changes.
Env example tweak
examples/CRISP/server/.env.example
Updates E3_DURATION from 70 to 100.
Dynamic import formatting
packages/enclave-contracts/tasks/ciphernode.ts, packages/enclave-contracts/tasks/enclave.ts, packages/enclave-contracts/tasks/program.ts
Replaces multi-line dynamic import blocks with single-line await import(...) forms; behavior unchanged.
ABI / Enclave interface changes
packages/enclave-contracts/contracts/interfaces/IEnclave.sol, packages/enclave-contracts/contracts/Enclave.sol, packages/enclave-contracts/contracts/registry/CiphernodeRegistryOwnable.sol, packages/enclave-contracts/artifacts/.../IEnclave.json
Adds bytes32 committeePublicKeyHash parameter to onCommitteePublished (interface, implementation, cross-contract call); stores committeePublicKeyHash and passes it in the publish flow; artifact ABI updated accordingly.
Build artifact metadata bumps
packages/enclave-contracts/artifacts/.../IBondingRegistry.json, .../ICiphernodeRegistry.json
Updated buildInfoId metadata strings; no ABI/behavioral changes.
Docs package manager metadata
docs/package.json
Adds packageManager property specifying pnpm version/hash.

Sequence Diagram(s)

sequenceDiagram
  participant CipherRegistry as CiphernodeRegistryOwnable
  participant Enclave as Enclave (contract)
  participant Storage as ChainState (e3s / publicKeyHashes)

  CipherRegistry->>Storage: store publicKeyHashes[e3Id] = publicKeyHash
  CipherRegistry->>Enclave: onCommitteePublished(e3Id, publicKeyHash)
  Enclave->>Storage: e3s[e3Id].committeePublicKey = committeePublicKeyHash
  Enclave-->>CipherRegistry: return (tx)
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Suggested labels

bug, chore

Suggested reviewers

  • ryardley
  • hmzakhalid
  • cedoor

Poem

🐰 I nibbled URLs and hopped a patch through,
CDN paths changed and PNPM got its cue.
Licenses, imports, a tiny env rate,
Keys now travel with the publish gate.
A rabbit’s fix — neat, quick, and true.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is partially related to the changeset. It accurately describes the bb.js URL update fix, which is the primary focus of one key change (the patch file and patchedDependencies config). However, the changeset contains many additional modifications beyond this (license changes, solhint config updates, E3_DURATION config, dynamic import refactoring, IEnclave interface updates, and build artifact updates) that are not captured by the title.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/crisp-e2e

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

ctrlc03
ctrlc03 previously approved these changes Feb 11, 2026

@ctrlc03 ctrlc03 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@package.json`:
- Around line 93-96: The root package.json currently applies a workspace-wide
patch under "patchedDependencies" for "@aztec/bb.js@3.0.0-nightly.20251104"
which affects both packages/enclave-sdk and examples/CRISP; add a clear TODO
note near the patchedDependencies entry referencing the exact dependency string
"@aztec/bb.js@3.0.0-nightly.20251104" and/or create a tracking issue ID and
include its number in the comment to remove this patch once upstream fixes CRS
endpoints so future maintainers know to revert it.
🧹 Nitpick comments (1)
packages/enclave-contracts/.solhint.json (1)

1-14: Unrelated change: Prettier plugin removal from solhint config.

This change (removing the Prettier plugin from solhint) appears unrelated to the stated PR objective of fixing the bb.js URL for CRISP e2e tests. Consider splitting it into a separate PR to keep the fix focused, or at minimum note it in the PR description.

Comment thread package.json

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@docs/package.json`:
- Around line 30-31: Update the packageManager value in docs/package.json to
include the exact sha512 integrity hash used across the workspace by replacing
the current "packageManager": "pnpm@10.7.1" entry with the full integrity string
("pnpm@10.7.1+sha512.2d92c86b7928dc8284f53494fb4201f983da65f0fb4f0d40baafa5cf628fa31dae3e5968f12466f17df7e97310e30f343a648baea1b9b350685dafafffdf5808")
so the packageManager field matches root and other workspace packages.

Comment thread docs/package.json Outdated
cedoor and others added 8 commits February 11, 2026 12:16
- Plugin targets solhint-community, incompatible with solhint
- Formatting still enforced via prettier:check

Co-authored-by: Cursor <cursoragent@cursor.com>
- Align docs/package.json packageManager with root and workspace packages
- Use full pnpm@10.7.1+sha512 hash for consistent version locking

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel vercel Bot temporarily deployed to Preview – crisp February 11, 2026 11:17 Inactive
@cedoor cedoor enabled auto-merge (squash) February 11, 2026 11:37
@cedoor cedoor merged commit c9045fe into main Feb 11, 2026
27 checks passed
@github-actions github-actions Bot deleted the fix/crisp-e2e branch February 19, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants