fix: update bb.js URL as a tmp fix for crisp e2e tests#1298
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughUpdates CRS fetch endpoints to a CDN in a patched bundle and TypeScript source, registers that patch in pnpm config, removes Prettier from solhint, changes a CRISP contract license header, adjusts an env example value, compacts several dynamic import statements, and adds a new committeePublicKeyHash parameter to Enclave-related interfaces and cross-contract calls. Changes
Sequence Diagram(s)sequenceDiagram
participant CipherRegistry as CiphernodeRegistryOwnable
participant Enclave as Enclave (contract)
participant Storage as ChainState (e3s / publicKeyHashes)
CipherRegistry->>Storage: store publicKeyHashes[e3Id] = publicKeyHash
CipherRegistry->>Enclave: onCommitteePublished(e3Id, publicKeyHash)
Enclave->>Storage: e3s[e3Id].committeePublicKey = committeePublicKeyHash
Enclave-->>CipherRegistry: return (tx)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@package.json`:
- Around line 93-96: The root package.json currently applies a workspace-wide
patch under "patchedDependencies" for "@aztec/bb.js@3.0.0-nightly.20251104"
which affects both packages/enclave-sdk and examples/CRISP; add a clear TODO
note near the patchedDependencies entry referencing the exact dependency string
"@aztec/bb.js@3.0.0-nightly.20251104" and/or create a tracking issue ID and
include its number in the comment to remove this patch once upstream fixes CRS
endpoints so future maintainers know to revert it.
🧹 Nitpick comments (1)
packages/enclave-contracts/.solhint.json (1)
1-14: Unrelated change: Prettier plugin removal from solhint config.This change (removing the Prettier plugin from solhint) appears unrelated to the stated PR objective of fixing the bb.js URL for CRISP e2e tests. Consider splitting it into a separate PR to keep the fix focused, or at minimum note it in the PR description.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/package.json`:
- Around line 30-31: Update the packageManager value in docs/package.json to
include the exact sha512 integrity hash used across the workspace by replacing
the current "packageManager": "pnpm@10.7.1" entry with the full integrity string
("pnpm@10.7.1+sha512.2d92c86b7928dc8284f53494fb4201f983da65f0fb4f0d40baafa5cf628fa31dae3e5968f12466f17df7e97310e30f343a648baea1b9b350685dafafffdf5808")
so the packageManager field matches root and other workspace packages.
- Plugin targets solhint-community, incompatible with solhint - Formatting still enforced via prettier:check Co-authored-by: Cursor <cursoragent@cursor.com>
- Align docs/package.json packageManager with root and workspace packages - Use full pnpm@10.7.1+sha512 hash for consistent version locking Co-authored-by: Cursor <cursoragent@cursor.com>
20b2471 to
5d86051
Compare
Re #1299
Summary by CodeRabbit
Chores
Style
Other