chore: new deployments addresses sepolia#1391
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis PR updates Sepolia contract addresses and deploy blocks across docs and deployed_contracts JSONs, bumps CRISP package versions to 0.7.0, renames the SDK sub-module reference from "encryption" to "crypto" in docs, adds three read-only Enclave SDK operations to the README, and simplifies a preset-name validation check in the Enclave SDK source. Changes
Sequence Diagram(s)(omitted — changes are primarily data/docs and small SDK validation/readers; no new multi-component control flow requiring a sequence diagram) Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Updated @crisp-e3/sdk to 0.7.0 - Updated @crisp-e3/contracts to 0.7.0 - Updated @crisp-e3/zk-inputs to 0.7.0 - Published to npm
952abf8 to
8ff2396
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/enclave-sdk/src/enclave-sdk.ts`:
- Around line 69-71: The validation currently throws when presetName is found in
ThresholdBfvParamsPresetNames (inverting the logic); change the condition in the
block that constructs/validates the preset (the check that throws new
SDKError('INVALID_THRESHOLD_BFV_PARAMS_PRESET_NAME')) to use
!ThresholdBfvParamsPresetNames.includes(presetName) so it throws only when
presetName is NOT a valid entry; update the throw message usage in the same
location (where SDKError is created) to remain the same but be guarded by the
corrected !includes() check.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b5b4d088-1e1e-44a5-87cb-5785cd5139ff
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (12)
docs/pages/ciphernode-operators/index.mdxdocs/pages/ciphernode-operators/running.mdxdocs/pages/sdk.mdxexamples/CRISP/client/package.jsonexamples/CRISP/packages/crisp-contracts/deployed_contracts.jsonexamples/CRISP/packages/crisp-contracts/package.jsonexamples/CRISP/packages/crisp-sdk/package.jsonexamples/CRISP/packages/crisp-zk-inputs/package.jsonpackages/enclave-contracts/deployed_contracts.jsonpackages/enclave-sdk/README.mdpackages/enclave-sdk/src/enclave-sdk.tstemplates/default/deployed_contracts.json
🚧 Files skipped from review as they are similar to previous changes (4)
- examples/CRISP/packages/crisp-zk-inputs/package.json
- examples/CRISP/packages/crisp-sdk/package.json
- examples/CRISP/packages/crisp-contracts/package.json
- examples/CRISP/client/package.json
8ff2396 to
38bcd94
Compare
update contract addresses on guide
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores