fix: template various fixes [skip-line-limit]#1434
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 WalkthroughWalkthroughThis PR removes the ACTIVATE_E3 step from the wizard workflow and introduces fee token approval before E3 requests. It adds wallet-based input publishing, enhances progress tracking in the encryption step, and updates context state from Changes
Sequence DiagramsequenceDiagram
actor User
participant Client as Client
participant RequestComp as RequestComputation
participant EnterInput as EnterInputs
participant EncryptSubmit as EncryptSubmit
participant Wallet as Wallet/Contract
participant E3Service as E3 Service
participant Results as Results
User->>Client: Start wizard
Client->>RequestComp: Request E3 computation
RequestComp->>E3Service: getE3Quote(requestParams)
E3Service-->>RequestComp: fee amount
RequestComp->>Wallet: approveFeeToken(fee)
Wallet-->>RequestComp: approval confirmed
RequestComp->>E3Service: requestE3(requestParams)
E3Service-->>RequestComp: E3_REQUESTED event (expiresAt)
RequestComp->>EnterInput: Auto-advance to ENTER_INPUTS
User->>EnterInput: Enter two numbers
EnterInput->>Wallet: walletClient.writeContract(publishInput)
Wallet-->>EnterInput: transaction hash (isCiphertextPublished=false)
EnterInput->>EncryptSubmit: Auto-advance to ENCRYPT_SUBMIT
EncryptSubmit->>E3Service: Subscribe to encryption events
E3Service-->>EncryptSubmit: E3_CIPHERTEXT_PUBLISHED (isCiphertextPublished=true)
EncryptSubmit->>EncryptSubmit: Poll expiration every 5s
E3Service-->>EncryptSubmit: E3_PLAINTEXT_OUTPUT (hasPlaintextOutput=true)
EncryptSubmit->>Results: Auto-advance with results
Results->>User: Display E3 ID, hash, output with copy buttons
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ctrlc03
changed the title
ctrlc03
changed the title
ctrlc03
changed the title
ctrlc03
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
templates/default/client/src/pages/steps/RequestComputation.tsx (2)
224-230:⚠️ Potential issue | 🟡 MinorUpdate the idle CTA to reference the fee token.
The request flow now quotes and approves
feeToken(MockUSDC in this template), but the idle label still says0.001 ETH. That points users at the wrong asset.💡 Suggested fix
- : 'Request E3 Computation (0.001 ETH)'} + : 'Request E3 Computation (fee token required)'}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@templates/default/client/src/pages/steps/RequestComputation.tsx` around lines 224 - 230, The idle CTA still shows the hardcoded string 'Request E3 Computation (0.001 ETH)'; update the JSX fallback branch so it references the dynamic fee token and amount instead of ETH — use the existing feeToken value (and the fee amount variable available in scope, e.g., fee/quotedFee/feeAmount) in the string returned by the tertiary expression that renders when !isRequesting && !e3State.isRequested, e.g. build a label like `Request E3 Computation (${feeAmount} ${feeToken.symbol || feeToken})` so the CTA reflects the actual token being quoted/approved.
126-130:⚠️ Potential issue | 🟠 MajorWait for transaction confirmation before marking the request as successful.
requestE3()returns the submitted tx hash immediately without waiting for confirmation. IfrequestSuccessis set true at that point, the CTA becomes clickable again (whenisRequestingclears infinally) beforee3State.isRequestedupdates via the E3Requested event. This leaves a window for duplicate-request submissions.💡 Suggested fix
const hash = await requestE3(requestParams) + await publicClient.waitForTransactionReceipt({ hash }) setLocalTransactionHash(hash) setLastTransactionHash(hash) setRequestSuccess(true)This follows the same pattern already used for the approval transaction above.
🧹 Nitpick comments (4)
templates/default/enclave.config.yaml (1)
7-22: Reduce drift risk between template sources of truth.
deploy_blockhere andblockNumberintemplates/default/deployed_contracts.jsonmust stay in lockstep. Consider generating one from the other during template generation to avoid future off-by-one regressions.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@templates/default/enclave.config.yaml` around lines 7 - 22, The template currently duplicates deployment heights: deploy_block fields in enclave.config.yaml and blockNumber fields in templates/default/deployed_contracts.json, risking drift; update the template generation pipeline so one canonical value is used and the other derived (e.g., when creating deployed_contracts.json set blockNumber = deploy_block from the enclave.config.yaml source, or vice versa), and modify the template generator code that emits the deploy_block and blockNumber values to read the canonical field (either "deploy_block" or "blockNumber") and compute the other to keep them in lockstep (referencing the deploy_block keys in enclave.config.yaml and the blockNumber keys in deployed_contracts.json).templates/default/client/src/pages/steps/Results.tsx (1)
22-29: Don’t silently swallow clipboard failures.Line 27 currently ignores copy errors. Add a small user-visible fallback/error state so failed copy attempts are actionable.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@templates/default/client/src/pages/steps/Results.tsx` around lines 22 - 29, The catch block in copyToClipboard silently swallows failures; update the catch to set a user-visible error state instead of doing nothing — for example, call setCopiedField with an error sentinel (e.g., 'copy-error') or trigger your existing toast/notification helper so the UI shows "Copy failed" and optionally include the error message, and ensure the temporary reset logic (setTimeout that clears setCopiedField) still runs for the error state; locate this behavior in the copyToClipboard function and adjust the catch to surface the failure to the user.templates/default/client/src/pages/steps/EncryptSubmit.tsx (1)
34-45: Use typed enclave event payloads instead ofany.Using
anyhere removes compile-time guarantees forevent.data.e3Id/plaintextOutputand makes event-shape regressions harder to catch.🔧 Proposed change
+type CiphertextOutputEvent = { data: { e3Id: bigint } } +type PlaintextOutputEvent = { data: { e3Id: bigint; plaintextOutput: string } } -const handleCiphertextOutput = (event: any) => { +const handleCiphertextOutput = (event: CiphertextOutputEvent) => { -const handlePlaintextOutput = (event: any) => { +const handlePlaintextOutput = (event: PlaintextOutputEvent) => {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@templates/default/client/src/pages/steps/EncryptSubmit.tsx` around lines 34 - 45, The handlers handleCiphertextOutput and handlePlaintextOutput currently accept event: any; define a typed payload interface (e.g., { e3Id: string; plaintextOutput?: string; /* other fields */ }) and change the parameter types to MessageEvent<YourPayload> (or the appropriate event type) for both handleCiphertextOutput and handlePlaintextOutput so event.data.e3Id and event.data.plaintextOutput are type-checked; update any places that read other fields on event.data to match the new interface.templates/default/scripts/dev_all_concurrently.sh (1)
18-18: Add a preflight check foranvilbefore launching concurrent services.Line 18 introduces a hard dependency on
anvil, but the script only validatespnpm. Failing fast keeps startup behavior predictable.🔧 Proposed change
# Check if pnpm is available if ! command -v pnpm &> /dev/null; then echo "ERROR: pnpm is not installed or not in PATH" echo "Please install pnpm or tmux to run this script" exit 1 fi + +# Check if anvil is available +if ! command -v anvil &> /dev/null; then + echo "ERROR: anvil is not installed or not in PATH" + echo "Please install Foundry (anvil) to run this script" + exit 1 +fi🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@templates/default/scripts/dev_all_concurrently.sh` at line 18, Add a preflight check to ensure the anvil binary is available before trying to run the "anvil --host 0.0.0.0 --chain-id 31337 --block-time 1 --mnemonic 'test test test test test test test test test test test junk' --silent" command; implement this by testing command availability (e.g., using command -v or which) early in the script alongside the existing pnpm check and if not found print a clear error like "anvil not found, please install anvil" and exit with non-zero status so the concurrent startup fails fast.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@templates/default/client/src/pages/steps/EnterInputs.tsx`:
- Around line 139-146: The CTA label doesn't reflect that the button is disabled
due to missing wallet; update the conditional rendering that produces the button
text (the block referencing input1, input2, e3State.isCommitteePublished,
e3State.publicKey) to first check walletClient and address and return a
wallet-specific label (e.g., "Connect Wallet" or "Reconnect Wallet") when either
is missing, otherwise preserve the existing "Waiting for Committee Key...",
"Enter Both Numbers", and "Proceed to Encryption" branches so users know they
must connect their wallet before proceeding.
In `@templates/default/client/src/pages/steps/RequestComputation.tsx`:
- Around line 122-124: Before calling approveFeeToken, ensure the wallet has
sufficient MockUSDC balance for the quoted fee: after computing fee via
sdk.sdk.getE3Quote(requestParams) and before sdk.sdk.approveFeeToken(fee), query
the fee-token balance (MockUSDC) for the signer using your token contract's
balanceOf or publicClient.getBalance equivalent, compare against fee.amount, and
if insufficient either trigger the dev faucet/mint flow for MockUSDC or throw a
clear error; keep the subsequent approveTx and
publicClient.waitForTransactionReceipt calls unchanged and only execute them
once the balance check/mint has succeeded so requestE3 will not fail due to
insufficient funds.
In `@templates/default/scripts/dev_frontend.sh`:
- Line 11: Capture the output of "enclave print-env --vite --chain localhost"
into a variable instead of using unquoted export $(...), check that variable is
non-empty and exit or warn if it is empty, and then safely export each key=value
pair (e.g., reading lines and export "$line") before running "pnpm dev"; replace
the current unquoted "$(enclave print-env ...)" usage with a quoted variable
reference and an explicit empty-check around that variable to prevent
word-splitting (SC2046) and silent continuation on empty output while preserving
the call to "pnpm dev".
---
Outside diff comments:
In `@templates/default/client/src/pages/steps/RequestComputation.tsx`:
- Around line 224-230: The idle CTA still shows the hardcoded string 'Request E3
Computation (0.001 ETH)'; update the JSX fallback branch so it references the
dynamic fee token and amount instead of ETH — use the existing feeToken value
(and the fee amount variable available in scope, e.g., fee/quotedFee/feeAmount)
in the string returned by the tertiary expression that renders when
!isRequesting && !e3State.isRequested, e.g. build a label like `Request E3
Computation (${feeAmount} ${feeToken.symbol || feeToken})` so the CTA reflects
the actual token being quoted/approved.
---
Nitpick comments:
In `@templates/default/client/src/pages/steps/EncryptSubmit.tsx`:
- Around line 34-45: The handlers handleCiphertextOutput and
handlePlaintextOutput currently accept event: any; define a typed payload
interface (e.g., { e3Id: string; plaintextOutput?: string; /* other fields */ })
and change the parameter types to MessageEvent<YourPayload> (or the appropriate
event type) for both handleCiphertextOutput and handlePlaintextOutput so
event.data.e3Id and event.data.plaintextOutput are type-checked; update any
places that read other fields on event.data to match the new interface.
In `@templates/default/client/src/pages/steps/Results.tsx`:
- Around line 22-29: The catch block in copyToClipboard silently swallows
failures; update the catch to set a user-visible error state instead of doing
nothing — for example, call setCopiedField with an error sentinel (e.g.,
'copy-error') or trigger your existing toast/notification helper so the UI shows
"Copy failed" and optionally include the error message, and ensure the temporary
reset logic (setTimeout that clears setCopiedField) still runs for the error
state; locate this behavior in the copyToClipboard function and adjust the catch
to surface the failure to the user.
In `@templates/default/enclave.config.yaml`:
- Around line 7-22: The template currently duplicates deployment heights:
deploy_block fields in enclave.config.yaml and blockNumber fields in
templates/default/deployed_contracts.json, risking drift; update the template
generation pipeline so one canonical value is used and the other derived (e.g.,
when creating deployed_contracts.json set blockNumber = deploy_block from the
enclave.config.yaml source, or vice versa), and modify the template generator
code that emits the deploy_block and blockNumber values to read the canonical
field (either "deploy_block" or "blockNumber") and compute the other to keep
them in lockstep (referencing the deploy_block keys in enclave.config.yaml and
the blockNumber keys in deployed_contracts.json).
In `@templates/default/scripts/dev_all_concurrently.sh`:
- Line 18: Add a preflight check to ensure the anvil binary is available before
trying to run the "anvil --host 0.0.0.0 --chain-id 31337 --block-time 1
--mnemonic 'test test test test test test test test test test test junk'
--silent" command; implement this by testing command availability (e.g., using
command -v or which) early in the script alongside the existing pnpm check and
if not found print a clear error like "anvil not found, please install anvil"
and exit with non-zero status so the concurrent startup fails fast.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: efb9e50d-3c95-4cf0-9d5f-b9d8d7e5ca64
📒 Files selected for processing (27)
docs/pages/ciphernode-operators/index.mdxpackages/enclave-contracts/contracts/verifier/RecursiveAggregationFoldVerifier.solpackages/enclave-contracts/contracts/verifier/ThresholdDecryptedSharesAggregationBnVerifier.solpackages/enclave-contracts/contracts/verifier/ThresholdDecryptedSharesAggregationModVerifier.solpackages/enclave-contracts/contracts/verifier/ThresholdPkAggregationVerifier.solpackages/enclave-contracts/ignition/modules/recursiveAggregationFoldVerifier.tspackages/enclave-contracts/ignition/modules/thresholdDecryptedSharesAggregationBnVerifier.tspackages/enclave-contracts/ignition/modules/thresholdDecryptedSharesAggregationModVerifier.tspackages/enclave-contracts/ignition/modules/thresholdPkAggregationVerifier.tspackages/enclave-contracts/test/fixtures/attestation.tspackages/enclave-contracts/test/fixtures/operators.tspackages/enclave-react/README.mdscripts/README.mdtemplates/default/client/src/context/WizardContext.tsxtemplates/default/client/src/pages/WizardRoutes.tsxtemplates/default/client/src/pages/components/ErrorDisplay.tsxtemplates/default/client/src/pages/steps/ActivateE3.tsxtemplates/default/client/src/pages/steps/EncryptSubmit.tsxtemplates/default/client/src/pages/steps/EnterInputs.tsxtemplates/default/client/src/pages/steps/RequestComputation.tsxtemplates/default/client/src/pages/steps/Results.tsxtemplates/default/client/src/utils/error-formatting.tstemplates/default/client/src/utils/input.tstemplates/default/deployed_contracts.jsontemplates/default/enclave.config.yamltemplates/default/scripts/dev_all_concurrently.shtemplates/default/scripts/dev_frontend.sh
💤 Files with no reviewable changes (5)
- packages/enclave-contracts/test/fixtures/operators.ts
- packages/enclave-react/README.md
- packages/enclave-contracts/test/fixtures/attestation.ts
- templates/default/client/src/pages/steps/ActivateE3.tsx
- templates/default/client/src/utils/error-formatting.ts
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
templates/default/scripts/dev_frontend.sh (1)
11-11:⚠️ Potential issue | 🟠 MajorFix unsafe
export $(...)usage on Line 11 (still unresolved).This still has SC2046 word-splitting risk and can silently proceed if
print-envis empty. This is the same issue already flagged earlier and should be fixed before merge.🔧 Proposed fix
-cd client && (export $(enclave print-env --vite --chain localhost) && pnpm dev) +ENV_VARS="$(enclave print-env --vite --chain localhost)" +if [ -z "${ENV_VARS}" ]; then + echo "ERROR: no Vite env vars found for chain 'localhost'" >&2 + exit 1 +fi + +cd client && ( + while IFS= read -r kv; do + export "$kv" + done < <(printf '%s\n' "${ENV_VARS}" | tr ' ' '\n') + pnpm dev +)#!/bin/bash # Verify SC2046 is gone and the line was updated safely. shellcheck -f gcc templates/default/scripts/dev_frontend.sh | rg -n 'SC2046|dev_frontend.sh:11' || true nl -ba templates/default/scripts/dev_frontend.sh | sed -n '8,20p'🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@templates/default/scripts/dev_frontend.sh` at line 11, The current subshell uses unsafe export $(enclave print-env ...) which causes SC2046 word-splitting and will silently proceed if output is empty; replace that pattern by capturing the output of enclave print-env --vite --chain localhost into a variable, check it’s non-empty, and then safely export each KEY=VALUE line (e.g., echo "$env" | while IFS= read -r line; do export "$line"; done) before running pnpm dev so you avoid word-splitting and handle empty output; update the pipeline that runs enclave print-env, the export logic, and the subsequent pnpm dev invocation in the dev_frontend.sh script.
🧹 Nitpick comments (3)
templates/default/client/src/pages/steps/Results.tsx (1)
22-30: Consider providing user feedback when clipboard copy fails.The empty catch block silently swallows clipboard errors. Users won't know if the copy failed. Consider showing a brief error indicator or logging for debugging.
💡 Suggested improvement
const copyToClipboard = async (text: string, field: string) => { try { await navigator.clipboard.writeText(text) setCopiedField(field) setTimeout(() => setCopiedField(null), 2000) } catch { - // Fallback for environments without clipboard API + // Fallback for environments without clipboard API + console.warn('Clipboard API unavailable') + // Optionally show a brief error state + setCopiedField(null) } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@templates/default/client/src/pages/steps/Results.tsx` around lines 22 - 30, The catch block in copyToClipboard silently swallows failures; update copyToClipboard to handle errors by (1) logging the error (console.error or processLogger) including the caught error and context (text/field), (2) providing user feedback such as setting an error state (e.g., setCopiedField to 'error' or a new setCopyError state) that the UI can render briefly, and (3) optionally falling back to document.execCommand('copy') if available; reference copyToClipboard, navigator.clipboard.writeText, and setCopiedField when adding the error handling and UI state updates.templates/default/client/src/pages/steps/EnterInputs.tsx (2)
63-68: FirstpublishInputtransaction is not awaited for confirmation before the second.Both inputs are published sequentially, but if the first transaction fails after being submitted (e.g., reverts on-chain), the second will still be attempted. Consider either:
- Awaiting transaction receipts between calls, or
- Documenting that partial failure is acceptable for this flow.
💡 Suggested improvement for robustness
+ const publicClient = sdk.sdk?.getPublicClient() + // Publish first input - await publishInput(walletClient, e3State.id, toHex(encryptedInput1), address, contracts.e3Program) + const hash1 = await publishInput(walletClient, e3State.id, toHex(encryptedInput1), address, contracts.e3Program) + if (publicClient) { + await publicClient.waitForTransactionReceipt({ hash: hash1 }) + } // Publish second input const hash2 = await publishInput(walletClient, e3State.id, toHex(encryptedInput2), address, contracts.e3Program)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@templates/default/client/src/pages/steps/EnterInputs.tsx` around lines 63 - 68, The first publishInput call is not confirmed before sending the second, risking partial failure; modify the flow in EnterInputs.tsx to wait for the first transaction to be mined/confirmed (use the wallet client's transaction-wait/receipt mechanism) after calling publishInput(walletClient, e3State.id, toHex(encryptedInput1), address, contracts.e3Program) and before invoking publishInput for encryptedInput2 (whose return value is currently assigned to hash2), and handle errors/retries so you don't proceed to the second publish if the first failed.
61-61: Consider using viem's built-intoHexutility.Viem provides a
toHexfunction that handles byte array conversion. This would reduce custom code and leverage the well-tested library implementation.💡 Suggested change
-import { hexToBytes } from 'viem' +import { hexToBytes, toHex } from 'viem' ... - const toHex = (bytes: Uint8Array): `0x${string}` => `0x${Array.from(bytes, (b) => b.toString(16).padStart(2, '0')).join('')}` + // Use viem's toHex directly on encryptedInput1 and encryptedInput2🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@templates/default/client/src/pages/steps/EnterInputs.tsx` at line 61, Replace the custom toHex implementation in EnterInputs.tsx with viem's built-in toHex: import toHex from 'viem' (or named import per viem version) and use that function wherever the local toHex const is referenced (remove the const toHex = ... declaration). Ensure the types expected by callers (Uint8Array input and `0x${string}` return) align with viem's toHex signature and adjust any local type annotations if needed.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@templates/default/scripts/dev_frontend.sh`:
- Line 11: The current subshell uses unsafe export $(enclave print-env ...)
which causes SC2046 word-splitting and will silently proceed if output is empty;
replace that pattern by capturing the output of enclave print-env --vite --chain
localhost into a variable, check it’s non-empty, and then safely export each
KEY=VALUE line (e.g., echo "$env" | while IFS= read -r line; do export "$line";
done) before running pnpm dev so you avoid word-splitting and handle empty
output; update the pipeline that runs enclave print-env, the export logic, and
the subsequent pnpm dev invocation in the dev_frontend.sh script.
---
Nitpick comments:
In `@templates/default/client/src/pages/steps/EnterInputs.tsx`:
- Around line 63-68: The first publishInput call is not confirmed before sending
the second, risking partial failure; modify the flow in EnterInputs.tsx to wait
for the first transaction to be mined/confirmed (use the wallet client's
transaction-wait/receipt mechanism) after calling publishInput(walletClient,
e3State.id, toHex(encryptedInput1), address, contracts.e3Program) and before
invoking publishInput for encryptedInput2 (whose return value is currently
assigned to hash2), and handle errors/retries so you don't proceed to the second
publish if the first failed.
- Line 61: Replace the custom toHex implementation in EnterInputs.tsx with
viem's built-in toHex: import toHex from 'viem' (or named import per viem
version) and use that function wherever the local toHex const is referenced
(remove the const toHex = ... declaration). Ensure the types expected by callers
(Uint8Array input and `0x${string}` return) align with viem's toHex signature
and adjust any local type annotations if needed.
In `@templates/default/client/src/pages/steps/Results.tsx`:
- Around line 22-30: The catch block in copyToClipboard silently swallows
failures; update copyToClipboard to handle errors by (1) logging the error
(console.error or processLogger) including the caught error and context
(text/field), (2) providing user feedback such as setting an error state (e.g.,
setCopiedField to 'error' or a new setCopyError state) that the UI can render
briefly, and (3) optionally falling back to document.execCommand('copy') if
available; reference copyToClipboard, navigator.clipboard.writeText, and
setCopiedField when adding the error handling and UI state updates.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: df88df95-b179-4690-99d6-b9a80e590ee2
📒 Files selected for processing (15)
packages/enclave-react/README.mdtemplates/default/client/src/context/WizardContext.tsxtemplates/default/client/src/pages/WizardRoutes.tsxtemplates/default/client/src/pages/components/ErrorDisplay.tsxtemplates/default/client/src/pages/steps/ActivateE3.tsxtemplates/default/client/src/pages/steps/EncryptSubmit.tsxtemplates/default/client/src/pages/steps/EnterInputs.tsxtemplates/default/client/src/pages/steps/RequestComputation.tsxtemplates/default/client/src/pages/steps/Results.tsxtemplates/default/client/src/utils/error-formatting.tstemplates/default/client/src/utils/input.tstemplates/default/deployed_contracts.jsontemplates/default/enclave.config.yamltemplates/default/scripts/dev_all_concurrently.shtemplates/default/scripts/dev_frontend.sh
💤 Files with no reviewable changes (3)
- templates/default/client/src/pages/steps/ActivateE3.tsx
- packages/enclave-react/README.md
- templates/default/client/src/utils/error-formatting.ts
🚧 Files skipped from review as they are similar to previous changes (4)
- templates/default/enclave.config.yaml
- templates/default/scripts/dev_all_concurrently.sh
- templates/default/client/src/pages/components/ErrorDisplay.tsx
- templates/default/deployed_contracts.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1209 and ensure template client works with the latest enclave changes
Summary by CodeRabbit
New Features
Improvements
Documentation