fix: replace hashset with BTreeSet for honest party ids

[hmzakhalid]

Summary by CodeRabbit

• Documentation

  • Clarified that BFV ciphertexts are ordered by ascending party_id.
  • Updated documentation for honest parties ordering across multiple components.
  • Added specifications for commitment data ordering consistency.

• Tests

  • Added a new consistency test verifying alignment between ciphertext and commitment data ordering.

• Improvements

  • Enhanced determinism in honest party ID ordering.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
crisp	Ready	Preview, Comment	Mar 25, 2026 11:54am
enclave-docs	Ready	Preview, Comment	Mar 25, 2026 11:54am

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3f7a843e-a7b6-44e9-95df-6bb24505ee6c

📥 Commits

Reviewing files that changed from the base of the PR and between ce3d331 and 48581e9.

📒 Files selected for processing (4)

• crates/events/src/enclave_event/compute_request/zk.rs
• crates/keyshare/src/threshold_keyshare.rs
• crates/zk-helpers/src/circuits/dkg/share_decryption/circuit.rs
• crates/zk-helpers/src/circuits/dkg/share_decryption/computation.rs

---

📝 Walkthrough

Walkthrough

The PR enforces deterministic ordering of honest parties and their ciphertexts across the DKG share-decryption flow by changing the honest_parties field from HashSet<u64> to BTreeSet<u64>, clarifying documentation about party-ID ordering, and adding a test to verify commitment consistency across the ordering scheme.

Changes

Cohort / File(s)	Summary
Documentation Updates crates/events/src/enclave_event/compute_request/zk.rs, crates/zk-helpers/src/circuits/dkg/share_decryption/circuit.rs	Clarified doc comments to specify that honest_ciphertexts_raw and honest_ciphertexts contain BFV ciphertexts ordered by ascending party_id.
Deterministic Party Ordering crates/keyshare/src/threshold_keyshare.rs	Changed honest_parties field type from Option<HashSet<u64>> to Option<BTreeSet<u64>> to enforce ascending party-ID ordering; updated construction and added debug assertion to verify honest_shares order alignment.
Test Addition crates/zk-helpers/src/circuits/dkg/share_decryption/computation.rs	Added test_commitment_ordering_consistency unit test to verify that computed expected commitments match direct commitment derivations across all honest party rows and modulus indices.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• refactor: missing circuits in zk-prover [skip-line-limit] #1317: Modifies ShareDecryptionCircuitData in the same share-decryption circuit file with additional field changes.
• feat: finalisation proofs [skip-line-limit] #1377: Modifies ThresholdKeyshareState and honest-parties handling in the same threshold-keyshare module.
• feat: verify share decryption proofs #1366: Overlaps on DKG share-decryption flow and ThresholdKeyshare.honest_parties field evolution.

Suggested reviewers

• ctrlc03
• cedoor

Poem

🐰 A HashSet once scattered with glee,
Now a BTreeSet, ordered you see!
Each party in line, from smallest to grand,
Commitments align across ciphertext land.
With tests that ensure the ordering's right,
Our DKG shines with deterministic light! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main structural change across multiple files: replacing HashSet with BTreeSet for honest_parties to ensure deterministic ordering by party_id.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/party-ordering

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[0xjei]

utACK