Skip to content

feat: add benches for secure and insecure [skip-line-limit]#1512

Merged
0xjei merged 1 commit into
mainfrom
benches
Apr 7, 2026
Merged

feat: add benches for secure and insecure [skip-line-limit]#1512
0xjei merged 1 commit into
mainfrom
benches

Conversation

@0xjei

@0xjei 0xjei commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated benchmarking infrastructure configuration with additional circuit entries.
    • Refreshed benchmark reports with latest measurement metrics.
    • Upgraded development toolchain versions for circuit compilation and proving systems.

@0xjei 0xjei enabled auto-merge (squash) April 7, 2026 14:52
@coderabbitai

coderabbitai Bot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Added a new circuit entry threshold/user_data_encryption to the benchmark configuration. Updated benchmark reports for both insecure and secure configurations with refreshed measurements, renamed circuits (e.g., decrypted_shares_aggregation), and split user_data_encryption into two distinct circuit variants with separate metrics.

Changes

Cohort / File(s) Summary
Benchmark Configuration
circuits/benchmarks/config.json
Added threshold/user_data_encryption circuit entry to the benchmarks circuits array.
Benchmark Reports
circuits/benchmarks/results_insecure/report.md, circuits/benchmarks/results_secure/report.md
Updated benchmark metrics with new measurements across DKG and Threshold sections. Renamed circuits (decrypted_shares_aggregation_mod/decrypted_shares_aggregation_bndecrypted_shares_aggregation), split user_data_encryption into user_data_encryption_ct0 and user_data_encryption_ct1, and refreshed compile/execute/prove/verify timing and opcode/gate/witness/circuit/vk/proof size data. Updated toolchain versions (Nargo/Barretenberg).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • ctrlc03
  • cedoor

Poem

🐰 Benchmarks updated, circuits aligned,
New metrics measured, carefully signed,
Encryption splits in measured way,
Thresholds tested, hop hooray!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references adding benches for secure and insecure variants, which aligns with the PR updating benchmark reports and configuration files for both secure and insecure circuits.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch benches

Warning

Review ran into problems

🔥 Problems

Timed out fetching pipeline failures after 30000ms


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel

vercel Bot commented Apr 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
crisp Ready Ready Preview, Comment Apr 7, 2026 2:53pm
enclave-docs Ready Ready Preview, Comment Apr 7, 2026 2:53pm

Request Review

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@circuits/benchmarks/results_secure/report.md`:
- Around line 38-56: The report omits the configured circuit
"user_data_encryption" that appears in circuits/benchmarks/config.json (and is
the parent of user_data_encryption_ct0/ct1); update report.md so both the
Summary table (lines 38-56) and the Circuit Details section (lines 156-253)
either include a benchmark row for "user_data_encryption" with its metrics or
explicitly add a "user_data_encryption — skipped/incomplete" row and a matching
note in the Circuit Details; ensure the entry references the same circuit name
"user_data_encryption" so the report remains complete and auditable relative to
the config.json listing.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2a2e0686-1741-43fc-8329-425b3d02a2dc

📥 Commits

Reviewing files that changed from the base of the PR and between bae26bf and dbb5558.

📒 Files selected for processing (3)
  • circuits/benchmarks/config.json
  • circuits/benchmarks/results_insecure/report.md
  • circuits/benchmarks/results_secure/report.md

Comment thread circuits/benchmarks/results_secure/report.md
@0xjei 0xjei merged commit 4a6aded into main Apr 7, 2026
33 checks passed
@github-actions github-actions Bot deleted the benches branch April 15, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants