Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThis PR updates cryptographic configuration parameters and circuit benchmarks across the FHE system: modifies secure DKG constants (modulus, bit-widths, encryption bounds), updates Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/enclave-contracts/scripts/deployEnclave.ts (1)
35-37: Consider adding a drift check for this duplicated secure tuple.These values now have to stay aligned with
crates/fhe-params/src/constants.rsand the circuit config changes in another language. A small parity test or generated artifact would make future parameter bumps much safer than relying on manual copy updates here.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/enclave-contracts/scripts/deployEnclave.ts` around lines 35 - 37, The duplicated constants plaintextModulus, moduli and error1Variance must be kept in sync with crates/fhe-params/src/constants.rs; add a small parity check or generate these values from the authoritative source during CI/build by implementing a script (e.g., a Node script or Rust helper) that reads/crates/fhe-params/src/constants.rs (or its compiled artifact) and verifies the values in packages/enclave-contracts/scripts/deployEnclave.ts match, failing the build if they diverge; wire this check into the test/CI pipeline so future parameter bumps are validated automatically.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/enclave-contracts/scripts/deployEnclave.ts`:
- Around line 35-37: The duplicated constants plaintextModulus, moduli and
error1Variance must be kept in sync with crates/fhe-params/src/constants.rs; add
a small parity check or generate these values from the authoritative source
during CI/build by implementing a script (e.g., a Node script or Rust helper)
that reads/crates/fhe-params/src/constants.rs (or its compiled artifact) and
verifies the values in packages/enclave-contracts/scripts/deployEnclave.ts
match, failing the build if they diverge; wire this check into the test/CI
pipeline so future parameter bumps are validated automatically.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ae580e97-39b1-4582-8cfb-03799626a7c8
⛔ Files ignored due to path filters (3)
Cargo.lockis excluded by!**/*.lockexamples/CRISP/Cargo.lockis excluded by!**/*.locktemplates/default/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
circuits/benchmarks/results_secure/report.mdcircuits/lib/src/configs/secure/dkg.nrcircuits/lib/src/configs/secure/threshold.nrcrates/fhe-params/src/constants.rspackages/enclave-contracts/scripts/deployEnclave.ts
This PR updates the secure parameter set (3 mod now) + the benchmark repo & release artifacts.
Summary by CodeRabbit