Skip to content

feat: make spawn dynamic to support large [skip-line-limit]#1584

Merged
0xjei merged 1 commit into
mainfrom
fix/large
Jun 6, 2026
Merged

feat: make spawn dynamic to support large [skip-line-limit]#1584
0xjei merged 1 commit into
mainfrom
fix/large

Conversation

@0xjei

@0xjei 0xjei commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Added support for "large" committee size option in benchmark configuration scripts (previously: micro, small, medium).
  • Tests

    • Updated integration tests to dynamically compute participant counts based on active committee parameters.

@vercel

vercel Bot commented Jun 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
crisp Ready Ready Preview, Comment Jun 6, 2026 7:52pm
enclave-docs Ready Ready Preview, Comment Jun 6, 2026 7:52pm
enclave-enclave-dashboard Building Building Preview Jun 6, 2026 7:52pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f0a02b8b-d8da-4849-90b1-a97708b4c995

📥 Commits

Reviewing files that changed from the base of the PR and between 71ffe30 and 947f8d9.

📒 Files selected for processing (5)
  • circuits/benchmarks/scripts/ensure_circuit_preset_built.sh
  • circuits/benchmarks/scripts/extract_crisp_verify_gas.sh
  • circuits/benchmarks/scripts/regenerate_report.sh
  • circuits/benchmarks/scripts/replay_folded_verify_gas.sh
  • crates/tests/tests/integration.rs

📝 Walkthrough

Walkthrough

The PR extends benchmark tooling support for larger committee configurations. Four shell scripts now validate and document large as a supported --committee option. The benchmark integration test is refactored to compute participant node count dynamically from committee parameters instead of hard-coding the value, enabling flexible test execution across different committee sizes.

Changes

Large committee support in benchmark scripts

Layer / File(s) Summary
Add large committee option to benchmark script validation
circuits/benchmarks/scripts/ensure_circuit_preset_built.sh, circuits/benchmarks/scripts/extract_crisp_verify_gas.sh, circuits/benchmarks/scripts/regenerate_report.sh, circuits/benchmarks/scripts/replay_folded_verify_gas.sh
All four benchmark scripts updated to accept large in --committee validation, with corresponding help text and error messages reflecting micro|small|medium|large as the complete valid set.

Dynamic benchmark participant node count

Layer / File(s) Summary
Compute participant count from committee parameters
crates/tests/tests/integration.rs
New benchmark_participant_node_count() helper function computes the number of registered participants as the threshold size plus sortition buffer, enabling the test to adapt participant count based on the active committee configuration.
Update test setup and validation for dynamic participant count
crates/tests/tests/integration.rs
Node spawning and sortition registration updated to use the computed participant count; comments clarified to reflect scaling with committee parameters; early validation added to ensure registered node set is large enough to form the target committee.
Update benchmark JSON output to use computed nodes_spawned
crates/tests/tests/integration.rs
Benchmark configuration JSON reporting replaces the hard-coded 20usize with the computed nodes_spawned variable, ensuring the recorded configuration matches the actual test execution.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • gnosisguild/enclave#1528: Introduced the benchmark gas/report scripts that are now being extended with large committee support.
  • gnosisguild/enclave#1578: Related benchmark tooling updates that also extend --committee CLI validation for the large option.

Suggested reviewers

  • cedoor

Poem

🐰 A rabbit hopped through benchmark scripts, adding large with glee,
While tests now count participants dynamically, as flexible as can be.
From hard-coded twenty to calculated might,
The committee grows gracefully into the night! 🌙✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: making spawn dynamic to support a large committee size. It clearly captures the primary modification across all affected files.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/large

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ctrlc03 ctrlc03 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@0xjei 0xjei merged commit f653c04 into main Jun 6, 2026
34 checks passed
@github-actions github-actions Bot deleted the fix/large branch June 14, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants