Skip to content

chore: update zkfhe-generator to latest version#986

Merged
cedoor merged 2 commits into
devfrom
chore/update-zkfhe-generator
Nov 7, 2025
Merged

chore: update zkfhe-generator to latest version#986
cedoor merged 2 commits into
devfrom
chore/update-zkfhe-generator

Conversation

@cedoor

@cedoor cedoor commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Release Notes

  • Chores

    • Updated project dependencies to support enhanced mathematical operations
  • New Features

    • Extended circuit input structure with new polynomial data field
    • Restructured bounds parameters to support granular boundary configurations

@cedoor cedoor requested a review from 0xjei November 7, 2025 18:04
@vercel

vercel Bot commented Nov 7, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
crisp Ready Ready Preview Comment Nov 7, 2025 6:39pm
enclave-docs Ready Ready Preview Comment Nov 7, 2025 6:39pm

@coderabbitai

coderabbitai Bot commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

The changes update the BFV helper dependencies and extend the ZK circuit inputs schema across Rust and TypeScript to support new ECDSA-related data (e1is field) while renaming bounds keys from a single e_bound to separate e0_bound and e1_bound keys.

Changes

Cohort / File(s) Summary
Dependency Management
crates/bfv-helpers/Cargo.toml
Added new dependency fhe-math from https://github.com/gnosisguild/fhe.rs and removed version pin from existing greco dependency.
Rust Backend - ZK Inputs Schema
examples/CRISP/crates/zk-inputs/src/lib.rs, examples/CRISP/crates/zk-inputs/src/serialization.rs
Added imports for Poly, Representation, BigInt, BigUint, ToBigInt. Introduced e1is: Vec<serde_json::Value> field to ZKInputs struct. Renamed bounds from single e_bound to separate e0_bound and e1_bound keys. Updated test assertions and mocks to reflect schema changes.
TypeScript Frontend - Circuit Types
examples/CRISP/packages/crisp-sdk/src/types.ts
Added new field e1is: Polynomial[] to CRISPCircuitInputs interface.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Pay particular attention to serialization.rs bounds renaming across all usages—verify e_bound → e0_bound and e1_bound mapping is complete and consistent.
  • Confirm the e1is serialization format in construct_inputs matches the expected structure in TypeScript consumer.
  • Verify test data structures properly include both e0_bound and e1_bound where applicable.

Possibly related PRs

Suggested reviewers

  • 0xjei
  • ctrlc03
  • ryardley

Poem

🐰 A schema springs forth, new fields take their place,
e1is bounded with grace and e0, e1 space,
From TypeScript to Rust, the data flows clear,
Dependencies dance—fhe-math brings good cheer!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions updating zkfhe-generator, but the PR primarily adds a new dependency (fhe-math) and introduces significant new fields (e1is) across multiple files. The version pin removal from greco and the title focus do not reflect the main changes. Revise the title to reflect the primary changes, such as 'Add e1is polynomial field support and new fhe-math dependency' or 'Add e1is field to ZKInputs and update dependencies'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/update-zkfhe-generator

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 78c0891 and a3c4674.

⛔ Files ignored due to path filters (2)
  • Cargo.lock is excluded by !**/*.lock
  • examples/CRISP/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • examples/CRISP/crates/zk-inputs/src/lib.rs (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • examples/CRISP/crates/zk-inputs/src/lib.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: build_enclave_cli
  • GitHub Check: build_sdk
  • GitHub Check: test_net
  • GitHub Check: integration_prebuild
  • GitHub Check: rust_unit
  • GitHub Check: test_contracts
  • GitHub Check: rust_integration
  • GitHub Check: Build & Push Image

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread crates/bfv-helpers/src/client.rs Outdated

@0xjei 0xjei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cedoor cedoor merged commit 1968881 into dev Nov 7, 2025
25 checks passed
@github-actions github-actions Bot deleted the chore/update-zkfhe-generator branch November 15, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants