Skip to content

chore: add static version of sdk in client#994

Merged
cedoor merged 3 commits into
mainfrom
chore/vercel-build
Nov 12, 2025
Merged

chore: add static version of sdk in client#994
cedoor merged 3 commits into
mainfrom
chore/vercel-build

Conversation

@cedoor

@cedoor cedoor commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Refactor

    • Simplified the build pipeline by removing the intermediate SDK build step and consolidating TypeScript compilation and bundling into a single flow.
  • Chores

    • Pinned the SDK dependency to a specific release (0.2.0-test) instead of using a workspace reference.

@cedoor cedoor marked this pull request as ready for review November 11, 2025 11:14
@vercel

vercel Bot commented Nov 11, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
crisp Skipped Skipped Nov 11, 2025 10:30pm
enclave-docs Skipped Skipped Nov 11, 2025 10:30pm

@coderabbitai

coderabbitai Bot commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

The CRISP client example's build configuration was simplified: the preparatory SDK build step was removed and the package now depends on a pinned SDK version (0.2.0-test) instead of a workspace reference. Vite config formatting was compacted without behavioral changes.

Changes

Cohort / File(s) Summary
Build pipeline & dependency
examples/CRISP/client/package.json
Removed build:sdk script; changed build from pnpm build:sdk && tsc && vite build to tsc && vite build; replaced "@crisp-e3/sdk": "workspace:*" with "@crisp-e3/sdk": "0.2.0-test"
Vite config formatting
examples/CRISP/client/vite.config.ts
Collapsed optimizeDeps.exclude array from multi-line to single-line formatting; no functional change

Sequence Diagram(s)

sequenceDiagram
  participant Dev as Developer
  participant ClientPkg as CRISP Client package.json
  participant TS as TypeScript (tsc)
  participant Vite as Vite build
  note right of ClientPkg: Old flow
  Dev->>ClientPkg: run `pnpm build` (old)
  ClientPkg->>ClientPkg: run `pnpm build:sdk`
  ClientPkg->>TS: run `tsc`
  ClientPkg->>Vite: run `vite build`

  rect rgba(100,200,150,0.08)
    note right of ClientPkg: New flow (changed)
    Dev->>ClientPkg: run `pnpm build` (new)
    ClientPkg->>TS: run `tsc`
    ClientPkg->>Vite: run `vite build`
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–15 minutes

  • Pay attention to examples/CRISP/client/package.json for potential CI/build assumptions relying on workspace SDK.
  • Confirm the pinned "0.2.0-test" SDK exists in registries used by CI and is intentional.

Possibly related PRs

Suggested reviewers

  • ctrlc03

Poem

🐰 With one script gone and a version set neat,

tsc and vite now skip the SDK beat.
A smaller chain, a lighter stride—
the rabbit hops on, build simplified! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: add static version of sdk in client' accurately describes the main change: replacing workspace dependency with a concrete version (0.2.0-test) in the client package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/vercel-build

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 12bd7b5 and 353253a.

📒 Files selected for processing (1)
  • examples/CRISP/client/vite.config.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • examples/CRISP/client/vite.config.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: build_enclave_cli
  • GitHub Check: integration_prebuild
  • GitHub Check: build_sdk
  • GitHub Check: test_net
  • GitHub Check: rust_unit
  • GitHub Check: test_contracts
  • GitHub Check: rust_integration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel vercel Bot temporarily deployed to Preview – crisp November 11, 2025 22:30 Inactive
@vercel vercel Bot temporarily deployed to Preview – enclave-docs November 11, 2025 22:30 Inactive
@cedoor cedoor requested a review from ctrlc03 November 11, 2025 22:55
Comment thread examples/CRISP/client/package.json
@cedoor cedoor requested a review from 0xjei November 12, 2025 09:30

@ctrlc03 ctrlc03 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cedoor cedoor enabled auto-merge (squash) November 12, 2025 11:25
@cedoor cedoor merged commit cf8dd2c into main Nov 12, 2025
23 checks passed
@ctrlc03 ctrlc03 deleted the chore/vercel-build branch November 12, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants